From: Andrew Morton <akpm@linux-foundation.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: lkml@metanurb.dk, linux-kernel@vger.kernel.org,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH] Make some ext3 kernel messages useful by showing device
Date: Mon, 9 Jun 2008 13:49:18 -0700 [thread overview]
Message-ID: <20080609134918.ed83d0d7.akpm@linux-foundation.org> (raw)
In-Reply-To: <484D3378.9090708@redhat.com>
On Mon, 09 Jun 2008 08:43:20 -0500
Eric Sandeen <sandeen@redhat.com> wrote:
> >
> > It is very much preferred, thanks.
> >
> > (patch retained for linux-ext4 review)
>
> The patch itself looks fine to me, and is a good idea. I recently saw a
> confused user on another fs where successful mount messages were
> followed by failure mount messages with no indication of which fs had
> the trouble...
>
> There probably are more spots in extX which could use this treatment...
> should we maybe just be using ext3_warning in more places, which
> automatically prints the sb, function name, etc?
Good point, thanks.
next prev parent reply other threads:[~2008-06-09 20:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-08 19:02 [PATCH] Make some ext3 kernel messages useful by showing device Kasper Sandberg
2008-06-09 9:59 ` Andrew Morton
2008-06-09 13:38 ` Kasper Sandberg
2008-06-09 20:48 ` Andrew Morton
2008-06-09 13:43 ` Eric Sandeen
2008-06-09 20:49 ` Andrew Morton [this message]
2008-06-09 22:08 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080609134918.ed83d0d7.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@metanurb.dk \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.