All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: jeff@garzik.org, netdev@vger.kernel.org, alan@redhat.com,
	randy.dunlap@oracle.com
Subject: Re: [patch 04/13] 8390: Split 8390 support into a pausing and a non pausing driver core
Date: Mon, 9 Jun 2008 17:15:32 -0700	[thread overview]
Message-ID: <20080609171532.32eb5a95.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080610005247.6230fec1@core>

On Tue, 10 Jun 2008 00:52:47 +0100
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> On Mon, 09 Jun 2008 16:33:49 -0700
> akpm@linux-foundation.org wrote:
> 
> > From: Alan Cox <alan@lxorguk.ukuu.org.uk>
> > 
> > Only a few ISA controllers need the pausing version of the 8390 core
> > while PCMCIA, later ISA and PCI do not. More importantly the ISA delays
> > can break non ISA boxes so we must use a different build of 8390.c for
> > the two sets of controllers.
> > 
> > No changes since last time as all the points of concerns raised proved to
> > be invalid
> > 
> > [randy.dunlap@oracle.com: ne2 (MCA) needs both 8390.o and 8390p.o functions]
> 
> ne2 does not need both, it hasn't needed both and its completely invalid
> to have both in one driver. Please drop Randy's change out and fix the
> actual typo instead.
> 

This patch sat in my tree for weeks causing build errors, then Randy
sent a fix and after that it didn't cause any build errors any more.

I do not know what typo you are referring to.


  reply	other threads:[~2008-06-10  0:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-09 23:33 [patch 04/13] 8390: Split 8390 support into a pausing and a non pausing driver core akpm
2008-06-09 23:52 ` Alan Cox
2008-06-10  0:15   ` Andrew Morton [this message]
2008-06-10  8:55     ` Alan Cox
2008-06-10  0:13 ` Alan Cox
2008-06-10  0:19   ` Andrew Morton
2008-06-10 10:20     ` Alan Cox
2008-06-11 18:25       ` Randy Dunlap
2008-06-12 21:10         ` Alan Cox
2008-06-12 21:37           ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080609171532.32eb5a95.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=alan@redhat.com \
    --cc=jeff@garzik.org \
    --cc=netdev@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.