Re: [PATCH 4/5] knfsd: convert knfsd to kthread API

[Jeff Layton <jlayton@redhat.com>]

On Tue, 10 Jun 2008 12:25:26 -0400
"J. Bruce Fields" <bfields@fieldses.org> wrote:

> On Tue, Jun 10, 2008 at 12:24:26PM -0400, bfields wrote:
> > On Tue, Jun 10, 2008 at 08:40:38AM -0400, Jeff Layton wrote:
> > In fact, I don't think you really need to take a reference till there's
> > a chance the new thread will decrement the reference--and since the
> > first thing the new thread does is take the mutex (which we're also
> > holding here), you could wait till after the succesful kthread_create()
> > to take the reference.  But maybe that's more fragile.  So I'd just
> > move the module_get to right before the kthread_create().
> 
> Anyway, that's very minor, and this all seems OK otherwise, so I might
> make this one small modification and just apply if there's no further
> comments.
> 
> --b.

Thanks. That sounds right to me. Let me know if you want me to formally
respin the patch instead.

Cheers,
-- 
Jeff Layton <jlayton@redhat.com>