From: Alex Chiang <achiang@hp.com>
To: Len Brown <lenb@kernel.org>
Cc: jbarnes@virtuousgeek.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
kaneshige.kenji@jp.fujitsu.com, Matthew Wilcox <matthew@wil.cx>,
Andrew Morton <akpm@linux-foundation.org>,
kristen.c.accardi@intel.com, greg@kroah.com, pbadari@us.ibm.com,
linux-pci@vger.kernel.org, pcihpd-discuss@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI: PCI slot detection driver
Date: Tue, 10 Jun 2008 15:17:00 -0600 [thread overview]
Message-ID: <20080610211700.GH25295@ldl.fc.hp.com> (raw)
In-Reply-To: <alpine.LFD.1.10.0806101418490.14381@localhost.localdomain>
* Len Brown <lenb@kernel.org>:
>
>
> > +#define ACPI_STA_FUNCTIONING (0x00000008)
>
> please use the existing define in acpi/actypes.h:
> #define ACPI_STA_DEVICE_FUNCTIONING 0x08
Ok, updated.
> I don't notice any breakage WRT ACPI usage here,
> I defer to Jesse on the PCI-ness parts.
>
> Acked-by: Len Brown <len.brown@intel.com>
Thanks!
/ac
next prev parent reply other threads:[~2008-06-10 21:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-04 20:08 [PATCH 0/4, v14] PCI, ACPI: Physical PCI slot objects Alex Chiang
2008-06-04 20:14 ` [PATCH] fakephp: Construct one fakephp slot per PCI slot Alex Chiang
2008-06-04 20:16 ` [PATCH] kobject: Export kobject_rename for pci_hotplug_core Alex Chiang
2008-06-04 23:55 ` Greg KH
2008-06-05 5:48 ` Andrew Morton
2008-06-05 6:05 ` Kenji Kaneshige
2008-06-05 6:33 ` Andrew Morton
2008-06-05 15:11 ` Alex Chiang
2008-06-06 4:07 ` Benjamin Herrenschmidt
2008-06-06 4:51 ` Alex Chiang
2008-06-06 23:20 ` Benjamin Herrenschmidt
2008-06-04 20:16 ` [PATCH] PCI: Introduce pci_slot Alex Chiang
2008-06-04 20:18 ` [PATCH] ACPI: PCI slot detection driver Alex Chiang
2008-06-10 18:24 ` Len Brown
2008-06-10 21:17 ` Alex Chiang [this message]
2008-06-05 2:32 ` [PATCH 0/4, v14] PCI, ACPI: Physical PCI slot objects Kenji Kaneshige
2008-06-05 3:07 ` Alex Chiang
2008-06-05 3:20 ` Kenji Kaneshige
2008-06-09 8:08 ` Kenji Kaneshige
2008-06-09 22:11 ` Alex Chiang
2008-06-10 3:04 ` Kenji Kaneshige
2008-06-10 3:12 ` Kenji Kaneshige
2008-06-10 19:24 ` Jesse Barnes
2008-06-10 21:19 ` Alex Chiang
2008-06-10 17:34 ` Alex Chiang
2008-06-11 1:48 ` Kenji Kaneshige
2008-06-11 2:53 ` Alex Chiang
2008-06-11 6:29 ` Kenji Kaneshige
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080610211700.GH25295@ldl.fc.hp.com \
--to=achiang@hp.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=greg@kroah.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=kristen.c.accardi@intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=pbadari@us.ibm.com \
--cc=pcihpd-discuss@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.