From: Cezary Jackiewicz <cezary.jackiewicz@gmail.com>
To: Richard Purdie <rpurdie@rpsys.net>
Cc: Len Brown <lenb@kernel.org>,
akpm@linux-foundation.org, linux-acpi@vger.kernel.org,
aystarik@gmail.com, hmh@hmh.eng.br
Subject: Re: [patch 06/11] misc,acpi,backlight: compal Laptop Extras
Date: Tue, 10 Jun 2008 23:51:36 +0200 [thread overview]
Message-ID: <20080610235136.7cda6369@debian> (raw)
In-Reply-To: <1213133339.5013.56.camel@dax.rpnet.com>
Dnia 2008-06-10, o godz. 22:28:59
Richard Purdie <rpurdie@rpsys.net> napisał(a):
> On Tue, 2008-06-10 at 12:55 -0400, Len Brown wrote:
> >
> > On Mon, 9 Jun 2008, akpm@linux-foundation.org wrote:
> >
> > > From: Cezary Jackiewicz <cezary.jackiewicz@gmail.com>
> > >
> > > This is driver for Compal Laptop: FL90/IFL90, based on MSI driver.
> > >
> > > This driver exports a few files in /sys/devices/platform/compal-laptop/:
> > > lcd_level - screen brightness: contains a single integer in the range 0..7 (rw)
> >
> > why is it a good idea to implement this platform specific lcd_level API
> > and at the same time implement the generic backlight API?
>
> I've asked about this before and suggested the lcd_level attribute be
> removed since the backlight API does everything that attribute does in a
> standardised way. I never did get a response.
>
Driver was rewritten from original msi driver, so this attribute was also
copied. I can remove it in a future version and use only standard backlight API.
--
Cezary
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-06-10 21:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-09 23:22 [patch 06/11] misc,acpi,backlight: compal Laptop Extras akpm
2008-06-10 16:55 ` Len Brown
2008-06-10 21:28 ` Richard Purdie
2008-06-10 21:51 ` Cezary Jackiewicz [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-05-14 23:09 akpm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080610235136.7cda6369@debian \
--to=cezary.jackiewicz@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aystarik@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.