From mboxrd@z Thu Jan 1 00:00:00 1970 From: sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org Subject: Re: [GIT PATCH] actually check va randomization Date: Wed, 11 Jun 2008 11:35:51 -0700 Message-ID: <20080611183551.GA32012@us.ibm.com> References: <481735A6.8070800@bull.net> <48173CE1.7050503@fr.ibm.com> <481ECA42.5060603@bull.net> <20080609130429.GA16297@us.ibm.com> <484D4612.9000901@bull.net> <20080609152336.GA27878@us.ibm.com> <484E1BD3.40401@ozlabs.au.ibm.com> <20080610181756.GB13817@us.ibm.com> <484F0DC7.5080209@ozlabs.au.ibm.com> <1213141919.7261.21.camel@nimitz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1213141919.7261.21.camel@nimitz> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Dave Hansen Cc: kathys , Containers , Cedric Le Goater , Nadia Derbey List-Id: containers.vger.kernel.org Dave Hansen [dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org] wrote: | Rather than just documenting this in the readme, actually spit | out a warning on it. Why not just bail out ? Its mostly unreliable at that point anyway. Besides, the warning can get buried in lot of other output. --- >From 84d005031a8a17bdca62dc541c296a3bea74658c Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Wed, 11 Jun 2008 11:22:17 -0700 Subject: [PATCH] cryo currently requires randomize_va_space to be 0. Fail if it is not. --- cr.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/cr.c b/cr.c index db3ada0..217c5e7 100644 --- a/cr.c +++ b/cr.c @@ -1464,6 +1464,7 @@ void check_for_va_randomize(void) return; fprintf(stderr, "WARNING: %s is set to: %d\n", VA_RANDOM_FILE, enabled); fprintf(stderr, " Please set to 0 to make cryo more reliable\n"); + exit(1); } void usage(void) -- 1.5.2.5