All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue@us.ibm.com>
To: lkml <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@osdl.org>
Subject: [PATCH -mm] mm/shmem.c: ret can be used uninitialized
Date: Wed, 11 Jun 2008 14:37:29 -0500	[thread overview]
Message-ID: <20080611193729.GD13365@us.ibm.com> (raw)

>From 6c4eb2ce2849308c4a745ec1f93001e5064a469c Mon Sep 17 00:00:00 2001
From: Serge Hallyn <serge@us.ibm.com>
Date: Wed, 11 Jun 2008 11:20:28 -0500
Subject: [PATCH -mm] mm/shmem.c: ret can be used uninitialized

Make sure ret is defined before check at line 1408.

Signed-off-by: Serge Hallyn <serge@us.ibm.com>
---
 mm/shmem.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/shmem.c b/mm/shmem.c
index ad24be7..b326ff2 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -1365,7 +1365,7 @@ repeat:
 		}
 
 		if (!filepage) {
-			int ret;
+			int ret = 0;
 
 			spin_unlock(&info->lock);
 			filepage = shmem_alloc_page(gfp, info, idx);
-- 
1.5.4.3


             reply	other threads:[~2008-06-12  0:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-11 19:37 Serge E. Hallyn [this message]
2008-06-12  1:24 ` [PATCH -mm] mm/shmem.c: ret can be used uninitialized Andrew Morton
2008-06-12 13:15   ` Serge E. Hallyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080611193729.GD13365@us.ibm.com \
    --to=serue@us.ibm.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.