All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ivo van Doorn <ivdoorn@gmail.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org,
	rt2400-devel@lists.sourceforge.net,
	Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: [PATCH] rt2x00: RT2X00_LIB_RFKILL should depend on INPUT
Date: Wed, 11 Jun 2008 22:01:00 +0200	[thread overview]
Message-ID: <200806112201.00496.IvDoorn@gmail.com> (raw)
In-Reply-To: <200806112119.27586.IvDoorn@gmail.com>

On Wednesday 11 June 2008, Ivo van Doorn wrote:
> rt2x00 requires the input-polldev driver for reporting rfkill events,
> selecting INPUT_POLLDEV is not correct since that option depends
> on the INPUT config option.
> Since RT2X00_LIB_RFKILL requires the input layer as well, we should
> make it depend on INPUT directly.
> 
> Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>

John, you can drop this patch in exchange for the patch just send by Randy,
since that patch would be more correct.

Thanks,

Ivo

> ---
> John, this is for 2.6.26
> 
> diff --git a/drivers/net/wireless/rt2x00/Kconfig b/drivers/net/wireless/rt2x00/Kconfig
> index 0ace761..c4d1f67 100644
> --- a/drivers/net/wireless/rt2x00/Kconfig
> +++ b/drivers/net/wireless/rt2x00/Kconfig
> @@ -36,6 +36,7 @@ config RT2X00_LIB_FIRMWARE
>  config RT2X00_LIB_RFKILL
>  	boolean
>  	depends on RT2X00_LIB
> +	depends on INPUT
>  	select RFKILL
>  	select INPUT_POLLDEV
>  
> 



      reply	other threads:[~2008-06-11 19:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-11 19:19 [PATCH] rt2x00: RT2X00_LIB_RFKILL should depend on INPUT Ivo van Doorn
2008-06-11 20:01 ` Ivo van Doorn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200806112201.00496.IvDoorn@gmail.com \
    --to=ivdoorn@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=randy.dunlap@oracle.com \
    --cc=rt2400-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.