From: Ian Kent <raven@themaw.net>
To: Jim Carter <jimc@math.ucla.edu>,
autofs mailing list <autofs@linux.kernel.org>
Subject: [PATCH 01/10] autofs4 - check for invalid dentry in getpath
Date: Thu, 12 Jun 2008 12:50:48 +0800 [thread overview]
Message-ID: <20080612045048.25151.55358.stgit@raven.themaw.net> (raw)
In-Reply-To: <20080612044425.25151.58126.stgit@raven.themaw.net>
Catch invalid dentry when calculating its path.
When autofs4_getpath() is called without the BKL (as it is when called
via ->unlocked_ioctl) it is possible to encounter a dentry that is in
the process of being freed which has a zero length name.
---
fs/autofs4/waitq.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c
index 1fe28e4..75e5955 100644
--- a/fs/autofs4/waitq.c
+++ b/fs/autofs4/waitq.c
@@ -171,7 +171,7 @@ static int autofs4_getpath(struct autofs_sb_info *sbi,
for (tmp = dentry ; tmp != root ; tmp = tmp->d_parent)
len += tmp->d_name.len + 1;
- if (--len > NAME_MAX) {
+ if (!len || --len > NAME_MAX) {
spin_unlock(&dcache_lock);
return 0;
}
next prev parent reply other threads:[~2008-06-12 4:50 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-12 4:50 [PATCH 00/10] Kernel patch series Ian Kent
2008-06-12 4:50 ` Ian Kent [this message]
2008-06-12 4:50 ` [PATCH 02/10] autofs4 - fix sparse warning in waitq.c:autofs4_expire_indirect() Ian Kent
2008-06-12 4:50 ` [PATCH 03/10] autofs4 - fix incorrect return from root.c:try_to_fill_dentry() Ian Kent
2008-06-12 4:51 ` [PATCH 04/10] autofs4 - fix mntput, dput order bug Ian Kent
2008-06-12 4:51 ` [PATCH 05/10] autofs4 - don't make expiring dentry negative Ian Kent
2008-06-12 4:51 ` [PATCH 06/10] autofs4 - use look aside list for lookups Ian Kent
2008-06-12 4:51 ` [PATCH 07/10] autofs4 - don't release directory mutex if called in oz_mode Ian Kent
2008-06-12 4:51 ` [PATCH 08/10] autofs4 - use lookup intent flags to trigger mounts Ian Kent
2008-06-12 4:51 ` [PATCH 09/10] autofs4 - use struct qstr in waitq.c Ian Kent
2008-06-12 4:51 ` [PATCH 10/10] autofs4 - fix pending mount race Ian Kent
2008-06-14 1:13 ` [PATCH 00/10] Kernel patch series Jim Carter
2008-06-14 3:30 ` Ian Kent
2008-06-14 3:42 ` Ian Kent
2008-06-19 0:40 ` clients suddenly start hanging (was: (no subject)) Jim Carter
2008-06-19 3:14 ` Ian Kent
2008-06-19 17:08 ` Jim Carter
2008-06-19 18:34 ` Jim Carter
2008-06-20 4:09 ` Ian Kent
2008-06-21 1:02 ` Jim Carter
2008-06-21 3:12 ` Ian Kent
2008-06-23 3:49 ` Jim Carter
2008-06-23 4:46 ` Ian Kent
2008-06-24 3:08 ` Ian Kent
2008-06-24 17:02 ` Stephen Biggs
2008-06-24 23:39 ` Jim Carter
2008-06-25 3:33 ` Ian Kent
2008-06-25 5:00 ` Ian Kent
2008-06-23 4:15 ` Ian Kent
-- strict thread matches above, loose matches on Subject: below --
2008-04-23 18:50 (no subject) Jim Carter
2008-04-23 20:04 ` Jeff Moyer
2008-04-24 3:10 ` Ian Kent
2008-04-24 16:52 ` clients suddenly start hanging (was: (no subject)) Jim Carter
2008-04-26 1:17 ` Jim Carter
2008-04-26 5:34 ` Ian Kent
2008-04-26 18:48 ` Jim Carter
2008-04-27 5:52 ` Ian Kent
2008-04-26 22:16 ` Jim Carter
2008-04-28 6:26 ` [PATCH 1/2] autofs4 - fix execution order race in mount request code Ian Kent
2008-05-08 4:52 ` clients suddenly start hanging (was: (no subject)) Jim Carter
2008-05-08 6:13 ` Ian Kent
2008-05-11 4:14 ` Jim Carter
2008-05-11 7:57 ` Ian Kent
2008-05-15 21:59 ` Jim Carter
2008-05-16 3:00 ` Ian Kent
2008-05-18 4:07 ` Ian Kent
2008-05-21 6:58 ` Ian Kent
2008-05-22 21:42 ` Jim Carter
2008-05-23 2:35 ` Ian Kent
2008-05-26 0:34 ` Jim Carter
2008-06-12 3:20 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080612045048.25151.55358.stgit@raven.themaw.net \
--to=raven@themaw.net \
--cc=autofs@linux.kernel.org \
--cc=jimc@math.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.