From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760645AbYFLMXE (ORCPT ); Thu, 12 Jun 2008 08:23:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759721AbYFLMWo (ORCPT ); Thu, 12 Jun 2008 08:22:44 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:51245 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759314AbYFLMWm (ORCPT ); Thu, 12 Jun 2008 08:22:42 -0400 Date: Thu, 12 Jun 2008 14:22:18 +0200 From: Ingo Molnar To: Peter Zijlstra Cc: Lai Jiangshan , Linux Kernel Mailing List Subject: Re: [PATCH 1/2] sched: fair group: fix overflow(was: fix divide by zero) Message-ID: <20080612122218.GA29661@elte.hu> References: <484F7AC5.8040206@cn.fujitsu.com> <1213168547.31518.66.camel@twins> <4850E192.3080804@cn.fujitsu.com> <1213260584.31518.86.camel@twins> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1213260584.31518.86.camel@twins> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0003] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Peter Zijlstra wrote: > > I think that (1UL << 18) is a good limited value: > > 1)it's not too large, we can create a lot of group before overflow > > 2)it's several times the weight value for nice=-19 (not too small) > > Thanks! > > Acked-by: Peter Zijlstra applied to tip/sched, thanks everyone. Ingo