All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: eranian@gmail.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch 12/21] perfmon2 minimal: sysfs interface
Date: Thu, 12 Jun 2008 20:53:39 -0700	[thread overview]
Message-ID: <20080613035339.GE17872@kroah.com> (raw)
In-Reply-To: <7c86c4470806120554w38a11307qa34511cf4f8b4aba@mail.gmail.com>

On Thu, Jun 12, 2008 at 02:54:15PM +0200, stephane eranian wrote:
> 
> In any case, let me know if there are still things that must be
> changed/simplified in my file.

This looks much better.  I wonder if you could use the "default" kobject
attributes, which might allow you to remove some of your show/store
wrappers, but in general, it's much better than before.

thanks,

greg k-h

  parent reply	other threads:[~2008-06-13  3:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-09 22:34 [patch 12/21] perfmon2 minimal: sysfs interface eranian
2008-06-11 14:49 ` Greg KH
2008-06-11 15:00   ` stephane eranian
2008-06-12 12:54     ` stephane eranian
2008-06-13  3:50       ` Greg KH
2008-06-13  3:53       ` Greg KH [this message]
2008-06-13 22:31         ` stephane eranian
2008-06-17  8:52           ` stephane eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080613035339.GE17872@kroah.com \
    --to=greg@kroah.com \
    --cc=eranian@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.