From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754670AbYFNQjp (ORCPT ); Sat, 14 Jun 2008 12:39:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753487AbYFNQjd (ORCPT ); Sat, 14 Jun 2008 12:39:33 -0400 Received: from casper.infradead.org ([85.118.1.10]:35893 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753234AbYFNQjc (ORCPT ); Sat, 14 Jun 2008 12:39:32 -0400 Date: Sat, 14 Jun 2008 02:39:16 -0700 From: Arjan van de Ven To: Ingo Molnar Cc: David Miller , torvalds@linux-foundation.org, akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, rjw@sisk.pl Subject: Re: [GIT]: Networking Message-ID: <20080614023916.431a868d@infradead.org> In-Reply-To: <20080614081656.GA27820@elte.hu> References: <20080612.211959.52937006.davem@davemloft.net> <20080614060320.GA18454@elte.hu> <20080614062758.GA23803@elte.hu> <20080614.001428.26649070.davem@davemloft.net> <20080614081656.GA27820@elte.hu> Organization: Intel X-Mailer: Claws Mail 3.3.1 (GTK+ 2.12.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 14 Jun 2008 10:16:56 +0200 Ingo Molnar wrote: > > ok, should we then remove that warning, if it's spurious? > kerneloops.org has picked up a few other instances of this warning as > well: > > http://www.kerneloops.org/searchfile.php?search=net%2Fsched%2Fsch_generic.c&btnG=Filename+Search the interesting thing is that there is a clear bias on which drivers are tripping this (r8169 is top when I counted yesterday, with sis900 second and then a long tail of nothing) that I think the WARN_ON() is useful in addition to the always-there printk. Eg it does help in seeing which driver is most likely to trigger this. (Andrew also thought this would trigger a *LOT*, so far it's only a rather modest amount, but it's waiting for Fedora or others to ship a kernel with this in to be sure) -- If you want to reach me at my work email, use arjan@linux.intel.com For development, discussion and tips for power savings, visit http://www.lesswatts.org