From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K7a9Z-0002WK-Hm for mharc-grub-devel@gnu.org; Sat, 14 Jun 2008 14:07:05 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K7a9X-0002UD-OA for grub-devel@gnu.org; Sat, 14 Jun 2008 14:07:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K7a9W-0002Rm-2A for grub-devel@gnu.org; Sat, 14 Jun 2008 14:07:03 -0400 Received: from [199.232.76.173] (port=37278 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K7a9V-0002RN-Pj for grub-devel@gnu.org; Sat, 14 Jun 2008 14:07:01 -0400 Received: from aybabtu.com ([69.60.117.155]:43710) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K7a9V-0005Om-HI for grub-devel@gnu.org; Sat, 14 Jun 2008 14:07:01 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1K7a7T-0001Bc-4O for grub-devel@gnu.org; Sat, 14 Jun 2008 20:04:58 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1K7a90-00064I-Pd for grub-devel@gnu.org; Sat, 14 Jun 2008 20:06:30 +0200 Date: Sat, 14 Jun 2008 20:06:30 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080614180630.GD5636@thorin> References: <1213372559.29669.14.camel@dv> <1213388057.21899.20.camel@dv> <20080614114344.GB5636@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Some concern about the journal support X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jun 2008 18:07:04 -0000 On Sun, Jun 15, 2008 at 01:32:23AM +0800, Bean wrote: > -/* Read LEN bytes from the block BLOCK on disk DISK into the buffer BUF, > - beginning with the block POS. Apply mappings from LOG. The blocks > - have a size of LOG2BLOCKSIZE (in log2). */ > -grub_err_t grub_fshelp_read (grub_disk_t disk, grub_fshelp_journal_t log, > - grub_disk_addr_t block, grub_off_t pos, > - grub_size_t len, char *buf, int log2blocksize) > -{ > [...] > - > -grub_disk_addr_t > -grub_fshelp_map_block (grub_fshelp_journal_t log, grub_disk_addr_t block) > -{ Why are these functions removed? I suppose they were only useful for journal handling? But they predate journal support, which is a bit confusing.. -- Robert Millan I know my rights; I want my phone call! What good is a phone call… if you are unable to speak? (as seen on /.)