From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K7aZG-00055c-V7 for mharc-grub-devel@gnu.org; Sat, 14 Jun 2008 14:33:39 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K7aZF-00054i-37 for grub-devel@gnu.org; Sat, 14 Jun 2008 14:33:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K7aZD-00053H-13 for grub-devel@gnu.org; Sat, 14 Jun 2008 14:33:36 -0400 Received: from [199.232.76.173] (port=50444 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K7aZC-000537-PZ for grub-devel@gnu.org; Sat, 14 Jun 2008 14:33:34 -0400 Received: from aybabtu.com ([69.60.117.155]:45905) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K7aZA-00019u-Pj for grub-devel@gnu.org; Sat, 14 Jun 2008 14:33:34 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1K7aX0-0001Fd-6d for grub-devel@gnu.org; Sat, 14 Jun 2008 20:31:19 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1K7aYb-0006HJ-QV for grub-devel@gnu.org; Sat, 14 Jun 2008 20:32:57 +0200 Date: Sat, 14 Jun 2008 20:32:57 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080614183257.GG5636@thorin> References: <20080531152125.GA14263@thorin> <200806140048.45062.okuji@enbug.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Environment block support for grub2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jun 2008 18:33:37 -0000 On Sat, Jun 14, 2008 at 11:41:18AM +0800, Bean wrote: > > Hi, > > No problem, I can find another name. Sorry, my mistake. I complained about $root being inappropiate for early stage use, but after that I noticed that $root is used in every stage to refer to "whatever drive we're currently accessing"; even before $prefix is initialised! I'm fine with $root if nobody objects. > BTW, there are now two schemes for locating device at boot, the > environment block and robert's uuid device, which one do you favor, or > is there other scheme you prefer ? I think there's no problem with having two schemes as long as they don't take extra core.img space (except for the rare use cases they're intended to) and don't conflict with each other. As for the "findroot" approach, I have two comments/ideas: - Since findroot.mod is basicaly an heuristic, and it's possible we may want different kinds of methods that work similarly, how about calling it "findroot_by_file" or something like that? Then we could have a separate module for "findroot_by_uuid", etc. - I think your idea has the potential of obsoleting some parts of our init routines, maybe (if we're lucky) making kernel.img smaller. For example, we currently make grub_prefix a static length string (could it be dynamic? -> less space); then try to extract $root from it, since we embedded it in the same place (if we had a scheme to specify it separately -> less code to parse it). -- Robert Millan I know my rights; I want my phone call! What good is a phone call… if you are unable to speak? (as seen on /.)