From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K7b4F-0002If-H7 for mharc-grub-devel@gnu.org; Sat, 14 Jun 2008 15:05:39 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K7b4D-0002Ia-UG for grub-devel@gnu.org; Sat, 14 Jun 2008 15:05:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K7b4B-0002IO-NA for grub-devel@gnu.org; Sat, 14 Jun 2008 15:05:36 -0400 Received: from [199.232.76.173] (port=53265 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K7b4B-0002IL-F3 for grub-devel@gnu.org; Sat, 14 Jun 2008 15:05:35 -0400 Received: from aybabtu.com ([69.60.117.155]:34963) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K7b4B-0005ix-5c for grub-devel@gnu.org; Sat, 14 Jun 2008 15:05:35 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1K7b2A-0001H0-RA for grub-devel@gnu.org; Sat, 14 Jun 2008 21:03:32 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1K7b3f-0006aN-0k for grub-devel@gnu.org; Sat, 14 Jun 2008 21:05:03 +0200 Date: Sat, 14 Jun 2008 21:05:03 +0200 From: Robert Millan To: grub-devel@gnu.org Message-ID: <20080614190502.GA25302@thorin> References: <20080606161357.GA13885@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20080606161357.GA13885@thorin> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] _chain can break stuff X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jun 2008 19:05:38 -0000 Committed. On Fri, Jun 06, 2008 at 06:13:57PM +0200, Robert Millan wrote: > > Turns out that right now, if you try to boot from LVM on ext3 with msdos > partmap, you get a core.img that is slightly too big to fit in the post-MBR > region. When you're booting from LVM, if it won't fit there you have no > other option, which makes this a big problem. > > If you remove _chain from the list, it fits again. Since _chain can make the > difference between core.img fitting or not fitting, I think it should not be > included unless user requests it. > > -- > Robert Millan > > I know my rights; I want my phone call! > What good is a phone call… if you are unable to speak? > (as seen on /.) > diff -x ChangeLog -x configure -x config.h.in -x CVS -x '*~' -x '*.mk' -urp ../grub2/util/i386/pc/grub-install.in ./util/i386/pc/grub-install.in > --- ../grub2/util/i386/pc/grub-install.in 2008-06-06 17:49:43.000000000 +0200 > +++ ./util/i386/pc/grub-install.in 2008-06-06 18:11:28.000000000 +0200 > @@ -231,8 +231,8 @@ partmap_module=`$grub_probe --target=par > # Device abstraction module, if any (lvm, raid). > devabstraction_module=`$grub_probe --target=abstraction --device ${grub_device}` > > -# _chain is often useful > -modules="$modules $fs_module $partmap_module biosdisk $devabstraction_module _chain" > +# The order in this list is critical. Be careful when modifiing it. > +modules="$modules $fs_module $partmap_module biosdisk $devabstraction_module" > > $grub_mkimage --output=${grubdir}/core.img --prefix=`make_system_path_relative_to_its_root ${grubdir}`/ $modules || exit 1 > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel -- Robert Millan I know my rights; I want my phone call! What good is a phone call… if you are unable to speak? (as seen on /.)