From: Christoph Hellwig <hch@lst.de>
To: xfs@oss.sgi.com
Subject: [PATCH] fix XFSQA 144
Date: Sat, 14 Jun 2008 21:22:48 +0200 [thread overview]
Message-ID: <20080614192248.GA24329@lst.de> (raw)
Two really dumb bugs:
- "foo & 0x3FFFFFFFFFFFF" doesn't cap at 1TB, but rather at more than
two magnitudes larger than that. That gets us EFBIG with typical
32bit XFS setups.
- the command array can easily overflow and thus let the test fail
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfstests/dmapi/src/suite2/src/test_fileattr.c
===================================================================
RCS file: /cvs/xfs-cmds/xfstests/dmapi/src/suite2/src/test_fileattr.c,v
retrieving revision 1.12
diff -u -p -r1.12 test_fileattr.c
--- xfstests/dmapi/src/suite2/src/test_fileattr.c 21 Sep 2007 04:15:06 -0000 1.12
+++ xfstests/dmapi/src/suite2/src/test_fileattr.c 14 Jun 2008 19:12:43 -0000
@@ -160,7 +160,7 @@ main(
char *ls_path;
char *pathname;
char test_file[100];
- char command[100];
+ char command[200];
int num_files=50;
dm_stat_t *stat_arr;
dm_stat_t dmstat;
@@ -244,7 +244,7 @@ main(
stat_arr[i].dt_uid=(uid_t)(rand()+rand()*0x10000);
stat_arr[i].dt_gid=(gid_t)(rand()+rand()*0x10000);
stat_arr[i].dt_mode=(mode_t)((rand()%4096)+32768);
- stat_arr[i].dt_size=((dm_off_t)(rand()+rand()*0x10000)) & 0x3FFFFFFFFFFFF; /* 1 TB max */
+ stat_arr[i].dt_size=((dm_off_t)(rand()+rand()*0x10000)) & 0x1FFFFFFFFFFULL; /* 1 TB max */
}
/*-----------------------------------------------------*\
next reply other threads:[~2008-06-14 19:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-14 19:22 Christoph Hellwig [this message]
2008-06-18 7:19 ` [PATCH] fix XFSQA 144 Donald Douwsma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080614192248.GA24329@lst.de \
--to=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.