From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K7zrP-00026i-DJ for mharc-grub-devel@gnu.org; Sun, 15 Jun 2008 17:34:03 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K7zrN-00026H-6T for grub-devel@gnu.org; Sun, 15 Jun 2008 17:34:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K7zrL-00025x-NA for grub-devel@gnu.org; Sun, 15 Jun 2008 17:34:00 -0400 Received: from [199.232.76.173] (port=39802 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K7zrL-00025u-Kj for grub-devel@gnu.org; Sun, 15 Jun 2008 17:33:59 -0400 Received: from aybabtu.com ([69.60.117.155]:60702) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K7zrL-0001Fm-5B for grub-devel@gnu.org; Sun, 15 Jun 2008 17:33:59 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1K7zpD-0007SC-AA for grub-devel@gnu.org; Sun, 15 Jun 2008 23:31:48 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1K7zqu-0002UZ-86 for grub-devel@gnu.org; Sun, 15 Jun 2008 23:33:32 +0200 Date: Sun, 15 Jun 2008 23:33:32 +0200 From: Robert Millan To: grub-devel@gnu.org Message-ID: <20080615213332.GA9442@thorin> References: <20080606160946.GA13716@thorin> <20080615182219.GA12911@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20080615182219.GA12911@thorin> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: new patch (boot from LVM / RAID) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jun 2008 21:34:01 -0000 On Sun, Jun 15, 2008 at 08:22:19PM +0200, Robert Millan wrote: > > The memdisk part of this was basicaly a bugfix, so I checked it in. The rest > seems to duplicate stuff that grub-setup was already doing, and I think I'll > have to take a closer look (I'll send another mail about that later). I think I sorted this out. The tip of the iceberg was that grub-setup is prepending a drive to prefix twice when we run LVM on RAID. However, it is actually wrong that grub-setup mangles prefix in first place! core.img might be loaded by other means (e.g. from GRUB Legacy), and then these adjustments have no effect. I also think it's more flexible if these kind of decisions are taken in a higher layer, so my patch moves this to grub-install, which relies on grub-probe. Then with grub-mkimage being capable of prepending a drive to prefix, there's no need to do it in grub-setup. This also fixes some minor issues I found along the way. Any comments? -- Robert Millan I know my rights; I want my phone call! What good is a phone call… if you are unable to speak? (as seen on /.)