From: "Jörn Engel" <joern@logfs.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: David Woodhouse <dwmw2@infradead.org>,
akpm@linux-foundation.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH RESEND] mtdpart: Avoid divide-by-zero on out-of-reach path
Date: Mon, 16 Jun 2008 10:33:56 +0200 [thread overview]
Message-ID: <20080616083356.GA15504@logfs.org> (raw)
In-Reply-To: <20080614.234540.102579992.anemo@mba.ocn.ne.jp>
On Sat, 14 June 2008 23:45:40 +0900, Atsushi Nemoto wrote:
>
> On "partition is out of reach" path, i.e. slave's offset was bigger
> than the master's size, slave's erasesize will not be calculated and
> it leads division by zero on following boundary checking. This patch
> makes calculation of the slave's erasesize more robust.
>
> This patch also contains some cleanups. Do not shadow symbol 'i',
> fold long lines, etc.
I personally consider the original long "for (...)" lines slightly
better (or rather less bad) than your replacement. Mixing cleanups
with bugfixes is often a bad idea.
Another reason is that I still cannot see the bugfix among all the
changes. *scratches head* Ah, here it is. *scratches some more* And
it even appears to be correct.
Can you resend as two patches?
Jörn
--
A victorious army first wins and then seeks battle.
-- Sun Tzu
next prev parent reply other threads:[~2008-06-16 8:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-14 14:45 [PATCH RESEND] mtdpart: Avoid divide-by-zero on out-of-reach path Atsushi Nemoto
2008-06-16 8:33 ` Jörn Engel [this message]
2008-06-16 14:30 ` Atsushi Nemoto
2008-06-16 14:57 ` Jörn Engel
2008-06-16 15:03 ` David Woodhouse
2008-06-17 14:09 ` Atsushi Nemoto
2008-06-17 14:10 ` David Woodhouse
2008-06-17 15:44 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080616083356.GA15504@logfs.org \
--to=joern@logfs.org \
--cc=akpm@linux-foundation.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.