From: Aurelien Jarno <aurelien@aurel32.net>
To: Julian Seward <jseward@acm.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ppc32 guests: fix computation of XER.{CA, OV} in addme, subfme, mullwo
Date: Tue, 17 Jun 2008 14:27:46 +0200 [thread overview]
Message-ID: <20080617122746.GA23769@volta.aurel32.net> (raw)
In-Reply-To: <200805110204.47184.jseward@acm.org>
On Sun, May 11, 2008 at 02:04:47AM +0200, Julian Seward wrote:
>
> For ppc32 guests, computation of XER.CA and XER.OV in some obscure
> cases is incorrect. At least, it doesn't produce the same results
> as a real MPC7447, and doesn't appear to be in accordance with the
> instruction set documentation.
>
> The attached patch fixes it:
>
> * addme{o}{.}, subfme{o}{.}: compute XER.CA correctly
>
> * mullwo{.}: sign extend arguments before doing 64-bit
> multiply, so as to make the XER.OV computation correct
Could you please give us a corner case for at least one of the
instructions? It would help to clearly understand the problem.
Thanks,
Aurelien
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
next prev parent reply other threads:[~2008-06-17 18:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-11 0:04 [Qemu-devel] [PATCH] ppc32 guests: fix computation of XER.{CA, OV} in addme, subfme, mullwo Julian Seward
2008-06-17 12:27 ` Aurelien Jarno [this message]
2008-06-17 22:06 ` Julian Seward
2008-06-17 22:53 ` J. Mayer
2008-06-17 23:23 ` Julian Seward
2008-06-18 21:32 ` J. Mayer
2008-06-18 21:39 ` Julian Seward
2008-06-18 22:09 ` J. Mayer
2008-06-18 22:13 ` Tristan Gingold
2008-06-19 7:36 ` Julian Seward
2008-06-19 8:36 ` Tristan Gingold
2008-06-19 9:12 ` J. Mayer
2008-10-01 21:47 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080617122746.GA23769@volta.aurel32.net \
--to=aurelien@aurel32.net \
--cc=jseward@acm.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.