From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K8ipu-000703-92 for mharc-grub-devel@gnu.org; Tue, 17 Jun 2008 17:35:30 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K8ipr-0006yS-Us for grub-devel@gnu.org; Tue, 17 Jun 2008 17:35:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K8ipo-0006uw-Da for grub-devel@gnu.org; Tue, 17 Jun 2008 17:35:25 -0400 Received: from [199.232.76.173] (port=38850 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K8ipo-0006ui-6J for grub-devel@gnu.org; Tue, 17 Jun 2008 17:35:24 -0400 Received: from gateway09.websitewelcome.com ([67.18.124.12]:53071) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1K8hPz-0008KD-Pp for grub-devel@gnu.org; Tue, 17 Jun 2008 16:04:40 -0400 Received: (qmail 27503 invoked from network); 17 Jun 2008 20:08:19 -0000 Received: from gator297.hostgator.com (74.53.228.114) by gateway09.websitewelcome.com with SMTP; 17 Jun 2008 20:08:19 -0000 Received: from c-67-185-142-228.hsd1.wa.comcast.net ([67.185.142.228]:46774 helo=localhost) by gator297.hostgator.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.68) (envelope-from ) id 1K8hPr-0007pA-P6 for grub-devel@gnu.org; Tue, 17 Jun 2008 15:04:31 -0500 Date: Tue, 17 Jun 2008 13:04:04 -0700 From: Colin D Bennett To: grub-devel@gnu.org Message-ID: <20080617130404.1e225725@gibibit.com> In-Reply-To: <1213731972.31285.13.camel@dv> References: <20080617105123.6547c227@gibibit.com> <1213731972.31285.13.camel@dv> X-Mailer: Claws Mail 3.4.0 (GTK+ 2.12.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator297.hostgator.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - gibibit.com X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] Fix grub-install to use prefix for modules dir X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jun 2008 21:35:29 -0000 On Tue, 17 Jun 2008 15:46:12 -0400 Pavel Roskin wrote: > On Tue, 2008-06-17 at 10:51 -0700, Colin D Bennett wrote: > > I fixed ``grub-install`` so it can function when installed > > to a prefix other than ``/usr/local``. This simply meant adding > > > > --directory="${pkglibdir} > > > > to the command line arguments for grub_mkimage. > > The default is GRUB_LIBDIR, which is set to pkglibdir at the compile > time. Your patch would have no effect if anything is compiled and > installed properly. > > Maybe you are trying to change prefix during "make install"? That's > not the best approach. DESTDIR should be used to install to a > temporary location. > > Or maybe you have some other scenario in mind? I'm not sure. All I know is that I did ./configure --prefix=/home/cdb/bin/grub && make && make install, then I tried to do /home/cdb/bin/grub/bin/grub-install /media/sdc1 and grub-mkimage was getting called with /usr/local/lib/something. Since I specified --prefix to configure, I expect grub never ever to refer to /usr/local. This patch fixed my problem. Colin