From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K8hT7-0006Sc-Tx for mharc-grub-devel@gnu.org; Tue, 17 Jun 2008 16:07:54 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K8hT2-0006NZ-5N for grub-devel@gnu.org; Tue, 17 Jun 2008 16:07:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K8hSx-0006IB-3k for grub-devel@gnu.org; Tue, 17 Jun 2008 16:07:45 -0400 Received: from [199.232.76.173] (port=39523 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K8hSw-0006Hv-Rm for grub-devel@gnu.org; Tue, 17 Jun 2008 16:07:42 -0400 Received: from gateway04.websitewelcome.com ([67.18.39.3]:41809) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1K8hSw-00023E-B8 for grub-devel@gnu.org; Tue, 17 Jun 2008 16:07:42 -0400 Received: (qmail 26016 invoked from network); 17 Jun 2008 20:12:29 -0000 Received: from gator297.hostgator.com (74.53.228.114) by gateway04.websitewelcome.com with SMTP; 17 Jun 2008 20:12:29 -0000 Received: from c-67-185-142-228.hsd1.wa.comcast.net ([67.185.142.228]:51063 helo=localhost) by gator297.hostgator.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.68) (envelope-from ) id 1K8hSp-0008G0-9h for grub-devel@gnu.org; Tue, 17 Jun 2008 15:07:35 -0500 Date: Tue, 17 Jun 2008 13:07:08 -0700 From: Colin D Bennett To: grub-devel@gnu.org Message-ID: <20080617130708.493de46a@gibibit.com> In-Reply-To: <1213732667.31285.19.camel@dv> References: <20080617104448.2b43f109@gibibit.com> <1213732667.31285.19.camel@dv> X-Mailer: Claws Mail 3.4.0 (GTK+ 2.12.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator297.hostgator.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - gibibit.com X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] Tidy up 'make' output X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jun 2008 20:07:50 -0000 On Tue, 17 Jun 2008 15:57:47 -0400 Pavel Roskin wrote: > On Tue, 2008-06-17 at 10:44 -0700, Colin D Bennett wrote: > > When thousands of long, wrapped lines full of command line options > > and file names are scrolling by on your terminal, it is very hard > > to pick out the irregularities in the build process, such as error > > and warnings. > > I like the idea, but the massive use of "override" doesn't looks > right. I'd rather see variables with different names used throughout > the makefiles. Linux makefiles don't use "override" at all. > "override" should be the last resort if everything else fails. Ok. Well, are implicit make rules ever used in the makefiles? If so, we would have to make them explicit in order to use a different compiler variable. I tried to touch the least number of things possible with my patch. If you wish, I can take a crack at eliminating the use of 'override' and using a different set of make variables for the instrumented calls to commands. Regards, Colin