From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K8jj8-00053E-Eh for mharc-grub-devel@gnu.org; Tue, 17 Jun 2008 18:32:34 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K8jj6-00052F-Ix for grub-devel@gnu.org; Tue, 17 Jun 2008 18:32:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K8jj3-00051d-Vf for grub-devel@gnu.org; Tue, 17 Jun 2008 18:32:32 -0400 Received: from [199.232.76.173] (port=57686 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K8jj3-00051a-Q6 for grub-devel@gnu.org; Tue, 17 Jun 2008 18:32:29 -0400 Received: from gateway08.websitewelcome.com ([67.18.34.19]:44491) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1K8jj3-0001dU-Oa for grub-devel@gnu.org; Tue, 17 Jun 2008 18:32:30 -0400 Received: (qmail 18499 invoked from network); 17 Jun 2008 22:40:45 -0000 Received: from gator297.hostgator.com (74.53.228.114) by gateway08.websitewelcome.com with SMTP; 17 Jun 2008 22:40:45 -0000 Received: from c-67-185-142-228.hsd1.wa.comcast.net ([67.185.142.228]:34328 helo=localhost) by gator297.hostgator.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.68) (envelope-from ) id 1K8jiv-0007nd-Ac for grub-devel@gnu.org; Tue, 17 Jun 2008 17:32:21 -0500 Date: Tue, 17 Jun 2008 15:31:54 -0700 From: Colin D Bennett To: grub-devel@gnu.org Message-ID: <20080617153154.143e2e20@gibibit.com> In-Reply-To: <20080617203710.GA31785@thorin> References: <20080617104448.2b43f109@gibibit.com> <20080617203710.GA31785@thorin> X-Mailer: Claws Mail 3.4.0 (GTK+ 2.12.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator297.hostgator.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - gibibit.com X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] Tidy up 'make' output X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jun 2008 22:32:33 -0000 On Tue, 17 Jun 2008 22:37:10 +0200 Robert Millan wrote: > On Tue, Jun 17, 2008 at 10:44:48AM -0700, Colin D Bennett wrote: > > with output that, in my opinion, makes it easier to see warnings and > > errors: > > > > COMPILE ../util/getroot.c > > COMPILE ../kern/device.c > > ../kern/device.c: In function 'grub_device_iterate': > > ../kern/device.c:84: warning: generating trampoline in object > > (requires executable stack) > > ../kern/device.c:84: warning: generating trampoline in object > > (requires executable stack) > > COMPILE ../kern/disk.c > > COMPILE ../kern/err.c > > COMPILE ../kern/misc.c > > I don't like the idea of hiding information this way. If the goal is > to catch warnings, I think -Werror can do a much better job (and > catching errors shouldn't be a problem unless you're using make -j or > -k). What about all the "trampoline" and strict-aliasing warnings (there must be hundreds of them)? I'm all for warning-free code, but if we try to use -Werror, the code won't even begin to compile in the current state.