From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K8f9Z-0006VP-9g for mharc-grub-devel@gnu.org; Tue, 17 Jun 2008 13:39:33 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K8f9X-0006V4-LW for grub-devel@gnu.org; Tue, 17 Jun 2008 13:39:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K8f9W-0006Ue-9Y for grub-devel@gnu.org; Tue, 17 Jun 2008 13:39:31 -0400 Received: from [199.232.76.173] (port=47152 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K8f9W-0006Ub-48 for grub-devel@gnu.org; Tue, 17 Jun 2008 13:39:30 -0400 Received: from aybabtu.com ([69.60.117.155]:59431) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K8f9W-0005h2-0L for grub-devel@gnu.org; Tue, 17 Jun 2008 13:39:30 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1K8f7D-0004qX-E4 for grub-devel@gnu.org; Tue, 17 Jun 2008 19:37:07 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1K8f92-0002FH-SS for grub-devel@gnu.org; Tue, 17 Jun 2008 19:39:00 +0200 Date: Tue, 17 Jun 2008 19:39:00 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080617173900.GA21729@thorin> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Patch for the open hackware X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jun 2008 17:39:31 -0000 On Tue, Jun 17, 2008 at 11:44:36PM +0800, Bean wrote: > + if (grub_ieee1275_test_flag (GRUB_IEEE1275_FLAG_CANNOT_INTERPRET)) > + { > + grub_addr_t addr; > + grub_uint32_t len; > + > + addr = HEAP_MAX_ADDR - HEAP_MIN_SIZE; > + len = HEAP_MIN_SIZE; > + > + if (grub_claimmap (addr, len) < 0) > + return grub_error (GRUB_ERR_OUT_OF_MEMORY, > + "Failed to claim heap at 0x%llx, len 0x%llx\n", > + addr, len); > + > + grub_mm_init_region ((void *) addr, len); > + } > + else > + grub_available_iterate (heap_init); > } This skips all the checks in heap_init(), which were intended for situations that could also apply to Open Hackware. Would be better if you call heap_init() with the desired parameters instead. -- Robert Millan I know my rights; I want my phone call! What good is a phone call… if you are unable to speak? (as seen on /.)