From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Subject: [patch 17/28] PNP: in debug resource dump, make empty list obvious Date: Tue, 17 Jun 2008 16:58:40 -0600 Message-ID: <20080617225911.166406993@ldl.fc.hp.com> References: <20080617225823.045233728@ldl.fc.hp.com> Return-path: Received: from g1t0027.austin.hp.com ([15.216.28.34]:24436 "EHLO g1t0027.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760366AbYFQW74 (ORCPT ); Tue, 17 Jun 2008 18:59:56 -0400 Content-Disposition: inline; filename=pnp-improve-debug-resource-dump Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Len Brown Cc: linux-acpi@vger.kernel.org, Rene Herman , linux-kernel@vger.kernel.org, Adam Belay , Adam M Belay , Li Shaohua , Matthieu Castet , Thomas Renninger , Rene Herman , Jaroslav Kysela , Andrew Morton , Takashi Iwai , Jiri Slaby If the resource list is empty, say that explicitly. Previously, it was confusing because often the heading was followed by zero resource lines, then some "add resource" lines from auto-assignment, so the "add" lines looked like current resources. Signed-off-by: Bjorn Helgaas Acked-by: Rene Herman Index: work10/drivers/pnp/support.c =================================================================== --- work10.orig/drivers/pnp/support.c 2008-05-16 16:01:26.000000000 -0600 +++ work10/drivers/pnp/support.c 2008-05-16 16:13:42.000000000 -0600 @@ -77,7 +77,12 @@ void dbg_pnp_show_resources(struct pnp_d struct pnp_resource *pnp_res; struct resource *res; - dev_dbg(&dev->dev, "current resources: %s\n", desc); + if (list_empty(&dev->resources)) { + dev_dbg(&dev->dev, "%s: no current resources\n", desc); + return; + } + + dev_dbg(&dev->dev, "%s: current resources:\n", desc); list_for_each_entry(pnp_res, &dev->resources, list) { res = &pnp_res->res; -- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761564AbYFQXGg (ORCPT ); Tue, 17 Jun 2008 19:06:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759705AbYFQXA0 (ORCPT ); Tue, 17 Jun 2008 19:00:26 -0400 Received: from g1t0027.austin.hp.com ([15.216.28.34]:24436 "EHLO g1t0027.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760366AbYFQW74 (ORCPT ); Tue, 17 Jun 2008 18:59:56 -0400 Message-Id: <20080617225911.166406993@ldl.fc.hp.com> References: <20080617225823.045233728@ldl.fc.hp.com> User-Agent: quilt/0.46-1 Date: Tue, 17 Jun 2008 16:58:40 -0600 From: Bjorn Helgaas To: Len Brown Cc: linux-acpi@vger.kernel.org, Rene Herman Cc: linux-kernel@vger.kernel.org Cc: Adam Belay Cc: Adam M Belay Cc: Li Shaohua Cc: Matthieu Castet Cc: Thomas Renninger Cc: Rene Herman Cc: Jaroslav Kysela Cc: Andrew Morton Cc: Takashi Iwai Cc: Jiri Slaby Subject: [patch 17/28] PNP: in debug resource dump, make empty list obvious Content-Disposition: inline; filename=pnp-improve-debug-resource-dump X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the resource list is empty, say that explicitly. Previously, it was confusing because often the heading was followed by zero resource lines, then some "add resource" lines from auto-assignment, so the "add" lines looked like current resources. Signed-off-by: Bjorn Helgaas Acked-by: Rene Herman Index: work10/drivers/pnp/support.c =================================================================== --- work10.orig/drivers/pnp/support.c 2008-05-16 16:01:26.000000000 -0600 +++ work10/drivers/pnp/support.c 2008-05-16 16:13:42.000000000 -0600 @@ -77,7 +77,12 @@ void dbg_pnp_show_resources(struct pnp_d struct pnp_resource *pnp_res; struct resource *res; - dev_dbg(&dev->dev, "current resources: %s\n", desc); + if (list_empty(&dev->resources)) { + dev_dbg(&dev->dev, "%s: no current resources\n", desc); + return; + } + + dev_dbg(&dev->dev, "%s: current resources:\n", desc); list_for_each_entry(pnp_res, &dev->resources, list) { res = &pnp_res->res; --