From: Ingo Molnar <mingo@elte.hu>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] modules: Take a shortcut for checking if an address is in a module
Date: Wed, 18 Jun 2008 12:00:41 +0200 [thread overview]
Message-ID: <20080618100041.GD15255@elte.hu> (raw)
In-Reply-To: <20080611081847.0b22079c@infradead.org>
* Arjan van de Ven <arjan@infradead.org> wrote:
> > Nothing wrong with the idea, but how about a nice
> > arch_maybe_module_addr() macro rather than ifdefs in module.c?
>
> Everytime someone says that, I go crawl under my desk and weep quietly
> for 10 minutes.
i've added your patch for testing purposes to tip/out-of-tree.
(An updated patch with the module.h change suggested by Rusty, as long
as acked by Rusty could go into tip/core/locking and thus show up in
linux-next as well.)
Ingo
prev parent reply other threads:[~2008-06-18 10:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-10 20:05 [PATCH] modules: Take a shortcut for checking if an address is in a module Arjan van de Ven
2008-06-11 11:12 ` Rusty Russell
2008-06-11 15:18 ` Arjan van de Ven
2008-06-11 18:54 ` Vegard Nossum
2008-06-18 9:57 ` Ingo Molnar
2008-06-18 10:24 ` Peter Zijlstra
2008-06-18 12:27 ` Rusty Russell
2008-06-12 0:20 ` Rusty Russell
2008-06-26 5:46 ` Rusty Russell
2008-06-26 11:48 ` Ingo Molnar
2008-06-18 10:00 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080618100041.GD15255@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.