All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Fischer <rep.dot.nop@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Fix nbd compile
Date: Wed, 18 Jun 2008 17:16:36 +0200	[thread overview]
Message-ID: <20080618151636.GA2172@mx.loc> (raw)
In-Reply-To: <87ej6u2317.fsf@macbook.be.48ers.dk>

On Wed, Jun 18, 2008 at 05:09:24PM +0200, Peter Korsgaard wrote:
>>>>>> "Thiago" == Thiago A Corr?a <thiago.correa@gmail.com> writes:
>
> Thiago> This will fix nbd compile, since all versions after 2.8 now
> Thiago> depends on glib.
>
>Thanks, committed.
>
>The only issue I saw was:
>
>-nbd: uclibc $(TARGET_DIR)/sbin/nbd-client
>+nbd: uclibc libglib2 $(TARGET_DIR)/sbin/nbd-client
>
>which doesn't work for parallel builds (libglib's staging install
>might not have completed before the configure step of nbd
>runs). Unfortunately this isn't easy to do with Makefile.autootools.in
>as the libglib version number is part of the .stamp_staging_installed
>path, and LIBGLIB2_TARGET_INSTALL_STAGING isn't defined yet if
>libglib2.mk gets parsed later than nbd.mk.
>
>Perhaps we should get rid of the package version in the stamp files?
>That would ofcause break if you changed package version, but it might
>be preferable to what we have now - E.G.:
>
>$(BUILD_DIR)/libglib2_stamp_staging_installed


echo the current package version into a .test_ver file in the toplevel
builddir, then cmp(1) .test_ver
$(BUILD_DIR)/$(PACK)_stamp_staging_installed. If cmp returns !0 then
rebuild and update the current version into the stamp-file

  reply	other threads:[~2008-06-18 15:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-18 14:45 [Buildroot] [PATCH] Fix nbd compile Thiago A. Corrêa
2008-06-18 15:09 ` Peter Korsgaard
2008-06-18 15:16   ` Bernhard Fischer [this message]
2008-06-18 15:29     ` Thiago A. Corrêa
2008-06-18 15:48       ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080618151636.GA2172@mx.loc \
    --to=rep.dot.nop@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.