From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrea Arcangeli <andrea@qumranet.com>
Subject: Re: [ANNOUNCE] kvm-70 release
Date: Wed, 18 Jun 2008 18:46:11 +0200
Message-ID: <20080618164611.GF9365@duo.random>
References: <48572C32.50009@qumranet.com> <4857A917.4040406@lfarkas.org> <485918B1.6080103@lfarkas.org> <g3bdhf$kql$1@ger.gmane.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, Farkas Levente <lfarkas@lfarkas.org>
To: Charles Duffy <Charles_Duffy@messageone.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from host36-195-149-62.serverdedicati.aruba.it ([62.149.195.36]:41702
	"EHLO mx.cpushare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751702AbYFRQqN (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 18 Jun 2008 12:46:13 -0400
Content-Disposition: inline
In-Reply-To: <g3bdhf$kql$1@ger.gmane.org>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Jun 18, 2008 at 11:35:58AM -0500, Charles Duffy wrote:
> Farkas Levente wrote:
>> kvm-70 do not compile on centos-5 kernel-2.6.18-53.1.21.el5
>
> Easy enough to work around, as kallsyms_lookup_name is only used in one 
> place:
>
> diff -ru kvm-70/kernel/external-module-compat.h 
> kvm-70.new/kernel/external-module-compat.h
> --- kvm-70/kernel/external-module-compat.h      2008-06-16 
> 13:25:16.000000000 -0500
> +++ kvm-70.new/kernel/external-module-compat.h  2008-06-17 
> 12:03:23.000000000 -0500
> @@ -663,7 +663,7 @@
>                               const enum hrtimer_mode mode);
>  extern int (*hrtimer_cancel_p)(struct hrtimer *timer);
>
> -#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,19) && 
> defined(CONFIG_KALLSYMS)
> +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,19) && 
> defined(CONFIG_KALLSYMS) && 0
>  static inline void hrtimer_kallsyms_resolve(void)
>  {
>         hrtimer_init_p = (void *) kallsyms_lookup_name("hrtimer_init");

Something's weird, if CONFIG_KALLSYMS isn't defined, the above code
shouldn't be selected already. Perhaps I'm missing something.

Farkas, can you send me /proc/config.gz by PM thanks!