From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K91hR-0004fw-Mo for mharc-grub-devel@gnu.org; Wed, 18 Jun 2008 13:44:01 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K91hQ-0004fC-B1 for grub-devel@gnu.org; Wed, 18 Jun 2008 13:44:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K91hP-0004eT-Lm for grub-devel@gnu.org; Wed, 18 Jun 2008 13:43:59 -0400 Received: from [199.232.76.173] (port=45827 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K91hP-0004eL-Dq for grub-devel@gnu.org; Wed, 18 Jun 2008 13:43:59 -0400 Received: from aybabtu.com ([69.60.117.155]:40680) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K91hP-0000fh-3F for grub-devel@gnu.org; Wed, 18 Jun 2008 13:43:59 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1K91ez-000701-TZ for grub-devel@gnu.org; Wed, 18 Jun 2008 19:41:30 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1K91gy-0006kF-9m for grub-devel@gnu.org; Wed, 18 Jun 2008 19:43:32 +0200 Date: Wed, 18 Jun 2008 19:43:32 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080618174332.GD25553@thorin> References: <20080617104448.2b43f109@gibibit.com> <20080617203710.GA31785@thorin> <48583933.4080208@coresystems.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <48583933.4080208@coresystems.de> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Tidy up 'make' output X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jun 2008 17:44:00 -0000 On Wed, Jun 18, 2008 at 12:22:43AM +0200, Stefan Reinauer wrote: > I would not consider this "hiding information". The information you see > (CFLAGS for example) don't really change across the lines and there's > always the chance to say V=1 to see all the compiler lines. The > opposite: The current forest of duplicate information is really what is > hiding the relevant information between a lot of uninteresting fuzz. > Maybe, you guys would prefer to set V=1 as the default, so one would > have to say V=0 to get above output? I am currently only compiling grub > with make -s, because that is the only way to get any decently parsable > output for finding issues in the code. Yeah you have a point here. > Please, please, don't use -Werror. GRUB2 is currently hard enough to > build and the build system is less than optimal and elegant. While I > agree that clean code never throughs warnings, the amazing number of > different gccs and build environments out there would make developing > for grub2 and compiling it very hard. There are quite a number of > warnings that do not matter because the developers simply know better > than the compiler. -Werror will lead to ugly workarounds to suppress > these warnings and make adoption of new tool chain versions a task from > hell. The problem with GRUB is that even a minor error can easily become critical if it prevents you from booting. Often -Werror can mean extra work just to shut up a warning (although I wouldn't consider this a workaround, unless there's some example I'm missing), but sometimes it can catch bugs that turn out to be really hard to debug, like those involving memory corruption. I think in the long run it would pay off. -- Robert Millan I know my rights; I want my phone call! What good is a phone call… if you are unable to speak? (as seen on /.)