From: David Miller <davem@davemloft.net>
To: wangchen@cn.fujitsu.com
Cc: shemminger@vyatta.com, netdev@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH net-next 3/8] bridge: Check return of dev_set_promiscuity
Date: Thu, 19 Jun 2008 19:08:54 -0700 (PDT) [thread overview]
Message-ID: <20080619.190854.188264452.davem@davemloft.net> (raw)
In-Reply-To: <485AFFE4.4000300@cn.fujitsu.com>
From: Wang Chen <wangchen@cn.fujitsu.com>
Date: Fri, 20 Jun 2008 08:55:00 +0800
Sigh...
> @@ -389,7 +389,10 @@ int br_add_if(struct net_bridge *br, struct net_device *dev)
> goto err2;
>
> rcu_assign_pointer(dev->br_port, p);
> - dev_set_promiscuity(dev, 1);
> + /* If promiscuity overflow, return error */
> + err = dev_set_promiscuity(dev, 1);
> + if (err)
> + goto err3;
Fixup this comment as I directed in my feedback for the previous patches.
These just look like turds all over the tree that you are adding for every
single dev_set_promiscuity() call site and it adds nothing to readability
or understandability of the code.
Anyways, Stephen also wanted you to implement this a different way.
prev parent reply other threads:[~2008-06-20 2:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 0:55 [PATCH net-next 3/8] bridge: Check return of dev_set_promiscuity Wang Chen
2008-06-20 1:18 ` Stephen Hemminger
2008-06-20 2:32 ` Wang Chen
2008-06-21 3:48 ` [PATCH] bridge: Check return of dev_set_promiscuity (v2) Stephen Hemminger
2008-06-21 5:45 ` [PATCH] bridge: Check return of dev_set_promiscuity (v3) Wang Chen
2008-06-20 2:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080619.190854.188264452.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=wangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.