Re: [PATCH] - Increase MAX_APICS for very large x86_64 configs

[Jack Steiner <steiner@sgi.com>]

On Thu, Jun 19, 2008 at 12:32:42PM +0200, Ingo Molnar wrote:
> 
> * Ingo Molnar <mingo@elte.hu> wrote:
> 
> > > The patch has no effect on any 32-bit kernel. It adds ~4k to the 
> > > size of 64-bit kernels but only if NR_CPUS > 255.
> > > 
> > > This is a repost of an earlier patch (4/16) that was implicated in a 
> > > random-qa failure. I have not been able to reproduce the failure 
> > > using the same boot args & config.  Best guess is that some other 
> > > patch caused random data corruption & this patch was a victim.
> > 
> > i have just re-tested the previously failing config on tip/master:
> > 
> >   http://redhat.com/~mingo/misc/config-Thu_Apr_17_10_17_14_CEST_2008.bad
> >   http://people.redhat.com/mingo/tip.git/README
> > 
> > and the good news is that it does not crash on bootup anymore. Perhaps 
> > one of Mike's fixes/improvements did the trick?
> 
> unfortunately it didnt last long, -tip randconfig auto-testing found 
> that your patch causes a bootup crash:
> 

I built a "git-checkout -b tip-latest tip/auto-latest" tree but get compile errors.
Is this the right tree??


Have you seen this before:



In file included from arch/x86/mm/srat_64.c:13:
include/linux/acpi.h:97:1: warning: "NR_NODE_MEMBLKS" redefined
In file included from include/acpi/platform/aclinux.h:59,
                 from include/acpi/platform/acenv.h:140,
                 from include/acpi/acpi.h:54,
                 from include/linux/acpi.h:39,
                 from arch/x86/mm/srat_64.c:13:
include/asm/acpi.h:165:1: warning: this is the location of the previous definition
arch/x86/mm/srat_64.c:101: error: expected identifier or '(' before 'do'
arch/x86/mm/srat_64.c:101: error: expected identifier or '(' before 'while'
arch/x86/mm/srat_64.c:108: error: expected identifier or '(' before 'do'
arch/x86/mm/srat_64.c:108: error: expected identifier or '(' before 'while'
arch/x86/mm/srat_64.c:211: error: expected identifier or '(' before 'do'
arch/x86/mm/srat_64.c:211: error: expected identifier or '(' before 'while'

...


--- jack