From: "Shawn O. Pearce" <spearce@spearce.org>
To: Teemu Likonen <tlikonen@iki.fi>
Cc: Dan McGee <dpmcgee@gmail.com>, git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] completion: add --graph to log command completion
Date: Thu, 19 Jun 2008 18:55:52 -0400 [thread overview]
Message-ID: <20080619225552.GQ11793@spearce.org> (raw)
In-Reply-To: <20080619224012.GA6705@mithlond.arda.local>
Teemu Likonen <tlikonen@iki.fi> wrote:
> I think I have already sent twice a patch with --graph completion.
I didn't Ack them because at the time --graph wasn't even in next
yet I think. Then I got busy and forgot. And --graph slipped
through into the 1.5.6 release without your bash completion patches.
Sorry.
> ---snip---
> bash: Add more option completions for 'git log'
>
> Options added: --graph --walk-reflogs --stat --numstat --shortstat
> --decorate --diff-filter= --color-words
>
> Signed-off-by: Teemu Likonen <tlikonen@iki.fi>
> ---
This conflicts with the patch you are replying to, but it makes
sense to do these options as well.
Acked-by: Shawn O. Pearce <spearce@spearce.org>
assuming the semantic (or merge) conflict on --graph is worked out.
;-)
> contrib/completion/git-completion.bash | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 506b40c..e78ca8e 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -761,6 +761,9 @@ _git_log ()
> --pretty= --name-status --name-only --raw
> --not --all
> --left-right --cherry-pick
> + --stat --numstat --shortstat
> + --decorate --diff-filter=
> + --color-words --walk-reflogs --graph
> "
> return
> ;;
> --
> 1.5.6.2.g3c3a
>
--
Shawn.
next prev parent reply other threads:[~2008-06-19 22:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-19 21:15 [PATCH] completion: add --graph to log command completion Dan McGee
2008-06-19 21:58 ` Shawn O. Pearce
2008-06-19 22:40 ` Teemu Likonen
2008-06-19 22:55 ` Shawn O. Pearce [this message]
2008-06-19 23:06 ` Dan McGee
2008-06-20 6:31 ` Teemu Likonen
2008-06-20 13:02 ` [PATCH v2] bash: Add more option completions for 'git log' Teemu Likonen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080619225552.GQ11793@spearce.org \
--to=spearce@spearce.org \
--cc=dpmcgee@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tlikonen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.