From: Ingo Molnar <mingo@elte.hu>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Michael Buesch <mb@bu3sch.de>,
David Ellingsworth <david@identd.dyndns.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH/RFC] remove irqs_disabled warning from local_bh_enable
Date: Fri, 20 Jun 2008 15:46:37 +0200 [thread overview]
Message-ID: <20080620134637.GA8135@elte.hu> (raw)
In-Reply-To: <1213774177.3803.164.camel@johannes.berg>
* Johannes Berg <johannes@sipsolutions.net> wrote:
> Subject: clean up and comment local_bh_enable code
>
> There's no need to use local_irq_save() over local_irq_disable() in
> the local_bh_enable code since it is a bug to call it with irqs
> disabled and do_softirq will enable irqs if there is any pending work.
> Consolidate the code from local_bh_enable and ..._ip to avoid having a
> disconnect between them in the warnings they trigger that is currently
> there. Also always trigger the warning on in_irq(), not just in the
> trace-irqflags case.
applied to tip/core/softirq for testing, thanks Johannes.
Ingo
next prev parent reply other threads:[~2008-06-20 13:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 21:57 [PATCH/RFC] remove irqs_disabled warning from local_bh_enable Johannes Berg
2008-06-17 23:08 ` David Miller
2008-06-17 23:55 ` Linus Torvalds
2008-06-18 7:01 ` Peter Zijlstra
2008-06-18 7:29 ` Johannes Berg
2008-06-20 13:46 ` Ingo Molnar [this message]
2008-06-20 15:27 ` Ingo Molnar
2008-06-20 15:36 ` Michael Buesch
2008-06-20 15:55 ` Ingo Molnar
2008-06-20 16:01 ` Michael Buesch
2008-06-20 16:18 ` Michael Buesch
2008-06-23 8:41 ` Ingo Molnar
2008-06-23 8:41 ` Ingo Molnar
2008-06-23 9:22 ` Michael Buesch
2008-06-27 5:33 ` Jeff Garzik
2008-06-27 10:53 ` Ingo Molnar
2008-06-27 10:56 ` Johannes Berg
2008-06-27 10:56 ` Johannes Berg
2008-06-20 15:43 ` Johannes Berg
2008-06-20 15:46 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080620134637.GA8135@elte.hu \
--to=mingo@elte.hu \
--cc=david@identd.dyndns.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.