From: Michael Buesch <mb@bu3sch.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: mac80211 suspend gotchas
Date: Fri, 20 Jun 2008 15:45:08 +0200 [thread overview]
Message-ID: <200806201545.08267.mb@bu3sch.de> (raw)
In-Reply-To: <1213968673.8967.178.camel@johannes.berg>
On Friday 20 June 2008 15:31:13 Johannes Berg wrote:
>
> > > This is not a hard problem to solve.
> >
> > > - suspend does, in this order (callback used):
> > > * stop aggregation (ampdu_action)
> > > * remove all keys (set_key)
> > > * remove all STAs (sta_notify)
> > > * remove all interfaces (remove_interface)
> > > * stop the hardware (stop)
> >
> > I think the hardware-stop should probably be done in the driver
> > suspend routine after the mac80211 notification and not by a mac80211 callback.
> > Otherwise this is going to get complicated wrt locking.
>
> All of those callbacks potentially require locks, you really want to
> call them outside of any locked section in your ->resume and ->suspend
> handlers.
ops->stop is special wrt suspend.
--
Greetings Michael.
prev parent reply other threads:[~2008-06-20 13:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 12:46 mac80211 suspend gotchas Johannes Berg
2008-06-20 13:07 ` Michael Buesch
2008-06-20 13:31 ` Johannes Berg
2008-06-20 13:45 ` Michael Buesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806201545.08267.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.