From: Bernhard Walle <bwalle@suse.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, yhlu.kernel@gmail.com
Subject: Re: [PATCH] Unify crashkernel reservation for 32 and 64 bit
Date: Fri, 20 Jun 2008 16:02:23 +0200 [thread overview]
Message-ID: <20080620160223.4a0f1dd8@halley.suse.de> (raw)
In-Reply-To: <20080620135645.GD8135@elte.hu>
* Ingo Molnar [2008-06-20 15:56]:
> * Bernhard Walle <bwalle@suse.de> wrote:
>
> > This patch moves the reserve_crashkernel() to setup.c and removes the
> > architecture-specific version. Both versions were more or less the
> > same.
>
> famous last words :)
>
> can you see any functionality difference between them? If yes, that
> should be declared.
The only difference was the calculation of memory -- it's more
complicated on i386 because of high memory support, so that was
outsourced to an inline function. However, because the highmem is in
#ifdef CONFIG_HIGHMEM
#endif
and CONFIG_HIGHMEM is off on x86-64, that doesn't matter. Do you see
another issue?
I tested it on both x86-64 and i386, with CONFIG_KEXEC on and off (so
that it compiles).
Bernhard
--
Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development
next prev parent reply other threads:[~2008-06-20 14:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 13:38 [PATCH] Unify crashkernel reservation for 32 and 64 bit Bernhard Walle
2008-06-20 13:38 ` Bernhard Walle
2008-06-20 13:56 ` Ingo Molnar
2008-06-20 14:02 ` Bernhard Walle [this message]
2008-06-20 14:37 ` Ingo Molnar
2008-06-20 13:58 ` Ingo Molnar
2008-06-20 14:06 ` Bernhard Walle
2008-06-20 14:23 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080620160223.4a0f1dd8@halley.suse.de \
--to=bwalle@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.