From: Andreas Herrmann <andreas.herrmann3@amd.com>
To: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
Suresh B Siddha <suresh.b.siddha@intel.com>
Subject: [PATCH 1/7] x86: introduce macro to check whether an address range is in the ISA range
Date: Fri, 20 Jun 2008 21:58:46 +0200 [thread overview]
Message-ID: <20080620195846.GC4105@alberich.amd.com> (raw)
In-Reply-To: <20080620195503.GB4105@alberich.amd.com>
Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
---
arch/x86/mm/ioremap.c | 2 +-
arch/x86/mm/pat.c | 5 ++---
include/asm-x86/e820.h | 1 +
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c
index 7452eb3..6d9960d 100644
--- a/arch/x86/mm/ioremap.c
+++ b/arch/x86/mm/ioremap.c
@@ -142,7 +142,7 @@ static void __iomem *__ioremap_caller(resource_size_t phys_addr,
/*
* Don't remap the low PCI/ISA area, it's always mapped..
*/
- if (phys_addr >= ISA_START_ADDRESS && last_addr < ISA_END_ADDRESS)
+ if (is_ISA_range(phys_addr, last_addr))
return (__force void __iomem *)phys_to_virt(phys_addr);
/*
diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c
index 227df3c..5bbc22e 100644
--- a/arch/x86/mm/pat.c
+++ b/arch/x86/mm/pat.c
@@ -215,7 +215,7 @@ int reserve_memtype(u64 start, u64 end, unsigned long req_type,
}
/* Low ISA region is always mapped WB in page table. No need to track */
- if (start >= ISA_START_ADDRESS && (end - 1) <= ISA_END_ADDRESS) {
+ if (is_ISA_range(start, end - 1)) {
if (ret_type)
*ret_type = _PAGE_CACHE_WB;
@@ -415,9 +415,8 @@ int free_memtype(u64 start, u64 end)
}
/* Low ISA region is always mapped WB. No need to track */
- if (start >= ISA_START_ADDRESS && end <= ISA_END_ADDRESS) {
+ if (is_ISA_range(start, end - 1))
return 0;
- }
spin_lock(&memtype_lock);
list_for_each_entry(ml, &memtype_list, nd) {
diff --git a/include/asm-x86/e820.h b/include/asm-x86/e820.h
index 7004251..5103d0b 100644
--- a/include/asm-x86/e820.h
+++ b/include/asm-x86/e820.h
@@ -24,6 +24,7 @@ struct e820map {
#define ISA_START_ADDRESS 0xa0000
#define ISA_END_ADDRESS 0x100000
+#define is_ISA_range(s, e) ((s) >= ISA_START_ADDRESS && (e) < ISA_END_ADDRESS)
#define BIOS_BEGIN 0x000a0000
#define BIOS_END 0x00100000
--
1.5.5.4
next prev parent reply other threads:[~2008-06-20 19:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 19:55 [PATCH 0/7] x86: pat.c: reserve_memtype strip down Andreas Herrmann
2008-06-20 19:58 ` Andreas Herrmann [this message]
2008-06-20 20:01 ` [PATCH 2/7] x86: pat.c choose more crisp variable names Andreas Herrmann
2008-06-20 20:03 ` [PATCH 3/7] x86: pat.c more trivial changes Andreas Herrmann
2008-06-20 20:04 ` [PATCH 4/7] x86: pat.c consolidate error/debug messages in reserve_memtype Andreas Herrmann
2008-06-20 20:05 ` [PATCH 5/7] x86: pat.c consolidate list_add handling " Andreas Herrmann
2008-06-20 20:07 ` [PATCH 6/7] x86: pat.c introduce function to check for conflicts with existing memtypes Andreas Herrmann
2008-06-21 6:20 ` Brice Goglin
2008-06-20 20:08 ` [PATCH 7/7] x86: pat.c final cleanup of loop body in reserve_memtype Andreas Herrmann
2008-06-24 11:08 ` [PATCH 0/7] x86: pat.c: reserve_memtype strip down Ingo Molnar
2008-06-24 21:59 ` Pallipadi, Venkatesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080620195846.GC4105@alberich.amd.com \
--to=andreas.herrmann3@amd.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.