All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Richard Henderson <rth@twiddle.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] alpha: resurrect Cypress IDE quirk
Date: Sat, 21 Jun 2008 20:45:11 +0200	[thread overview]
Message-ID: <200806212045.12982.bzolnier@gmail.com> (raw)
In-Reply-To: <20080620232854.GD8061@jurassic.park.msu.ru>

On Saturday 21 June 2008, Ivan Kokshaysky wrote:
> Which was removed in the hope that generic legacy IDE quirk in
> drivers/pci/probe.c is sufficient for Cypress IDE.
> It isn't, as this controller has non-standard BAR layout:
> secondary channel registers are in the BAR0-1 of the second
> PCI function - not in the BAR2-3 of the same function, as the
> generic quirk routine assumes.
> 
> Signed-off-by: Ivan Kokshaysky <ink@jurassic.park.msu.ru>

ACK, thanks for fixing it.

This actually reminds me that we should probably limit cy82c693
driver to be selectable only on alpha (I've never seen this chipset
being used on anything else + quick googling for non-alpha dmesgs
seems to confirm it)?

From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: [PATCH] ide: limit cy82c693 host driver to ALPHA

Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 drivers/ide/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Index: b/drivers/ide/Kconfig
===================================================================
--- a/drivers/ide/Kconfig
+++ b/drivers/ide/Kconfig
@@ -510,6 +510,7 @@ config BLK_DEV_TRIFLEX
 
 config BLK_DEV_CY82C693
 	tristate "CY82C693 chipset support"
+	depends on ALPHA
 	select IDE_TIMINGS
 	select BLK_DEV_IDEDMA_PCI
 	help

      reply	other threads:[~2008-06-21 19:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-20 23:28 [PATCH] alpha: resurrect Cypress IDE quirk Ivan Kokshaysky
2008-06-21 18:45 ` Bartlomiej Zolnierkiewicz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200806212045.12982.bzolnier@gmail.com \
    --to=bzolnier@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=ink@jurassic.park.msu.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rth@twiddle.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.