Re: [PATCH] i2c: virtual i2c adapter support.

[Rodolfo Giometti <giometti-AVVDYK/kqiJWk0Htik3J/w@public.gmane.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1685 bytes --]

On Sun, Jun 22, 2008 at 10:37:16AM +0200, Peter Korsgaard wrote:
> >>>>> "Rodolfo" == Rodolfo Giometti <giometti-k2GhghHVRtY@public.gmane.org> writes:
> 
> Hi,
> 
>  Rodolfo> +
>  Rodolfo> +struct i2c_adapter *i2c_add_virt_adapter(struct i2c_adapter *parent,
>  Rodolfo> +				struct i2c_client *client,
>  Rodolfo> +				u32 force_nr, u32 mux_val,
>  Rodolfo> +				int (*select_cb) (struct i2c_adapter *,
>  Rodolfo> +						struct i2c_client *, u32),
>  Rodolfo> +				int (*deselect_cb) (struct i2c_adapter *,
>  Rodolfo> +						struct i2c_client *, u32))
>  Rodolfo> +{
> 
> How about changing the struct i2c_client to an anonymous void *data
> instead so it can be used for systems where the multiplexing hardware
> isn't a i2c device? E.G. I have a driver (currently not in mainline)
> for a I2C multiplexer implemented in a FPGA together with the
> opencores I2C controller:
> [snip] 
> It would be nice to be able to use the i2c-virtual stuff for it.

Mmm... I suppose is not so easy as we wish since there are several
references to the i2c parent struct into the code.

I suppose you can get better result if you define your i2c multiplexer
as a dummy i2c device. The you can force it to be connected with a
real i2c parent by using the i2c_register_board_info() function.

What do you think about this solution? :)

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail: giometti-AVVDYK/kqiJWk0Htik3J/w@public.gmane.org
Linux Device Driver                          giometti-k2GhghHVRtY@public.gmane.org
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c