From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
rmk@arm.linux.org.uk, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [2.6 patch] fix BLK_DEV_HD_ONLY on ARM dependencies
Date: Sun, 22 Jun 2008 15:21:33 +0200 [thread overview]
Message-ID: <200806221521.33506.bzolnier@gmail.com> (raw)
In-Reply-To: <20080622101752.GG27069@cs181133002.pp.htv.fi>
On Sunday 22 June 2008, Adrian Bunk wrote:
> On Tue, Jun 10, 2008 at 07:56:15PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > On Tuesday 10 June 2008, Adrian Bunk wrote:
> > > This patch limits BLK_DEV_HD_ONLY to the ARM platforms offering
> > > IRQ_HARDDISK, fixing the following compile error on others:
> > >
> > > <-- snip -->
> > >
> > > ...
> > > CC drivers/ide/legacy/hd.o
> > > ...
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c: In function 'hd_times_out':
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c:542: error: 'IRQ_HARDDISK' undeclared (first use in this function)
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c:542: error: (Each undeclared identifier is reported only once
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c:542: error: for each function it appears in.)
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c: In function 'do_hd_request':
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c:661: error: 'IRQ_HARDDISK' undeclared (first use in this function)
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c: In function 'hd_init':
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c:765: error: 'IRQ_HARDDISK' undeclared (first use in this function)
> > > make[3]: *** [drivers/ide/legacy/hd.o] Error 1
> > >
> > > <-- snip -->
> > >
> > > Reported-by: Adrian Bunk <bunk@kernel.org>
> > > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> >
> > applied, thanks
> >
> > BTW Could you look into converting your "remove BLK_DEV_HD_ONLY" patch
> > into "move old hd driver to drivers/block/" one because the old hd driver
> > still has some uses (as noticed by Alan)?
>
> drivers/ide/Makefile says:
> # old hd driver must be last
>
> Is this still true?
Yep.
> If yes then moving the driver to drivers/block/ requires switching to
> late_initcall() since drivers/block/ is linked before drivers/ide/ .
Care to cook a patch?
Thanks,
Bart
next prev parent reply other threads:[~2008-06-22 13:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-09 22:21 [2.6 patch] fix BLK_DEV_HD_ONLY on ARM dependencies Adrian Bunk
2008-06-10 17:56 ` Bartlomiej Zolnierkiewicz
2008-06-22 10:17 ` Adrian Bunk
2008-06-22 13:21 ` Bartlomiej Zolnierkiewicz [this message]
2008-06-24 21:54 ` [0/5] move hd.c to drivers/block/ Adrian Bunk
2008-06-25 20:16 ` Bartlomiej Zolnierkiewicz
2008-06-24 21:54 ` [1/5] remove BLK_DEV_HD_ONLY Adrian Bunk
2008-06-24 21:54 ` [2/5] ide/legacy/hd.c: use late_initcall() Adrian Bunk
2008-06-24 21:54 ` [3/5] move ide/legacy/hd.c to drivers/block/ Adrian Bunk
2008-06-24 21:55 ` [4/5] update the BLK_DEV_HD help text Adrian Bunk
2008-06-24 22:05 ` [5/5] hd.c: remove the #include <linux/mc146818rtc.h> Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806221521.33506.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bunk@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.