All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm-devel <kvm@vger.kernel.org>
Subject: Re: RFC: cache_regs in kvm_emulate_pio
Date: Sun, 22 Jun 2008 15:05:07 -0300	[thread overview]
Message-ID: <20080622180507.GA12595@dmt.cnet> (raw)
In-Reply-To: <485DE023.4060006@qumranet.com>

On Sun, Jun 22, 2008 at 08:16:19AM +0300, Avi Kivity wrote:
> Looks good, but we can aim higher.  The cache_regs() API was always  
> confusing (I usually swap the two parts).  If we replace all ->regs  
> access with accessors, we can make it completely transparent.
>
> It will be tricky in the emulator, but worthwhile, no?

Yes, agree. Will go for accessors.

Thanks.



  reply	other threads:[~2008-06-22 18:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-21 19:46 RFC: cache_regs in kvm_emulate_pio Marcelo Tosatti
2008-06-22  5:16 ` Avi Kivity
2008-06-22 18:05   ` Marcelo Tosatti [this message]
2008-06-24 19:33   ` Marcelo Tosatti
2008-06-26  9:18     ` Avi Kivity
2008-06-26 14:52       ` Marcelo Tosatti
2008-06-26 22:15       ` Marcelo Tosatti
2008-06-27  2:28         ` Marcelo Tosatti
  -- strict thread matches above, loose matches on Subject: below --
2008-06-19 23:31 Marcelo Tosatti
2008-06-20 20:30 ` Avi Kivity
2008-06-20 21:24   ` Marcelo Tosatti
2008-06-21  7:04     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080622180507.GA12595@dmt.cnet \
    --to=mtosatti@redhat.com \
    --cc=avi@qumranet.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.