From: meyering@sourceware.org <meyering@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW tools/lvmcmdlib.c
Date: 23 Jun 2008 09:27:45 -0000 [thread overview]
Message-ID: <20080623092745.8672.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: meyering at sourceware.org 2008-06-23 09:27:45
Modified files:
. : WHATS_NEW
tools : lvmcmdlib.c
Log message:
lvm2_run: don't return uninitialized for _memlock_inc or _memlock_dec
* tools/lvmcmdlib.c: Initialize "ret". Also avoid useless string
comparison.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.910&r2=1.911
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvmcmdlib.c.diff?cvsroot=lvm2&r1=1.6&r2=1.7
--- LVM2/WHATS_NEW 2008/06/23 09:25:07 1.910
+++ LVM2/WHATS_NEW 2008/06/23 09:27:45 1.911
@@ -1,5 +1,6 @@
Version 2.02.39 -
================================
+ lvm2_run: Don't return uninitialized "ret" for _memlock_inc or _memlock_dec.
Avoid link failure when configuring without --enable-cmdlib.
Avoid link failure when configuring without --enable-readline.
Make clvmd return immediately if other nodes are down in an openais cluster.
--- LVM2/tools/lvmcmdlib.c 2008/01/30 14:00:02 1.6
+++ LVM2/tools/lvmcmdlib.c 2008/06/23 09:27:45 1.7
@@ -1,6 +1,6 @@
/*
* Copyright (C) 2001-2004 Sistina Software, Inc. All rights reserved.
- * Copyright (C) 2004-2007 Red Hat, Inc. All rights reserved.
+ * Copyright (C) 2004-2008 Red Hat, Inc. All rights reserved.
*
* This file is part of LVM2.
*
@@ -79,9 +79,10 @@
}
/* FIXME Temporary - move to libdevmapper */
+ ret = ECMD_PROCESSED;
if (!strcmp(cmdline, "_memlock_inc"))
memlock_inc();
- if (!strcmp(cmdline, "_memlock_dec"))
+ else if (!strcmp(cmdline, "_memlock_dec"))
memlock_dec();
else
ret = lvm_run_command(cmd, argc, argv);
reply other threads:[~2008-06-23 9:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080623092745.8672.qmail@sourceware.org \
--to=meyering@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.