Re: [PATCH] i2c: twl4030: warning: mixed declarations and code

[Tony Lindgren <tony@atomide.com>]

* Eduardo Valentin <edubezval@gmail.com> [080611 17:04]:
> Hi Balbi,
> 
> On Wed, Jun 11, 2008 at 9:55 AM, Felipe Balbi <felipe.balbi@nokia.com> wrote:
> > On Wed, Jun 11, 2008 at 09:53:45AM -0400, ext Eduardo Valentin wrote:
> >> > -       struct twl4030_usb *twl = xceiv_to_twl(xceiv);
> >> >        u32 l;
> >> > +       struct twl4030_usb *twl = xceiv_to_twl(xceiv);
> >>
> >> To me you are just moving the place of this declaration.
> >
> > Yes, because ISO C99 forbids mixed declaraction and code. build
> > tlw4030-usb and you'll see the warning. ;-)
> 
> Ok. I'd suggest changing the commit message to
> i2c: twl4030: C99 warning: mixed declarations and code
> 
> But this is up to you :)

Pushing today, that driver is not in mainline yet so the comments are
just fine.

Tony