All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Kentaro Makita <k-makita@np.css.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	viro@ZenIV.linux.org.uk, harvey.harrison@gmail.com
Subject: Re: [RESEND][PATCH -mm 1/2] vfs: fix coding style at dcache.c.
Date: Mon, 23 Jun 2008 19:07:05 -0700	[thread overview]
Message-ID: <20080623190705.04cedae2.akpm@linux-foundation.org> (raw)
In-Reply-To: <486051AA.8000507@np.css.fujitsu.com>

On Tue, 24 Jun 2008 10:45:14 +0900 Kentaro Makita <k-makita@np.css.fujitsu.com> wrote:

> o fix coding style at dcache.c. No behavior changed.
> 
> Signed-off-by: Kentaro Makita <k-makita@np.css.fujitsu.com>
> ---
>  fs/dcache.c |   21 ++++++++++-----------
>  1 files changed, 10 insertions(+), 11 deletions(-)
> 
> Index: b/fs/dcache.c
> ===================================================================
> --- a/fs/dcache.c	2008-06-05 11:44:26.000000000 +0900
> +++ b/fs/dcache.c	2008-06-05 11:48:57.000000000 +0900
> @@ -453,15 +453,15 @@ static void __shrink_dcache_sb(struct su
>  	int cnt = 0;
> 
>  	BUG_ON(!sb);
> -	BUG_ON((flags & DCACHE_REFERENCED) && count == NULL);
> +	BUG_ON((flags & DCACHE_REFERENCED) && !count);

A change like this isn't really a "fix".  Both styles are acceptable
and some people prefer the longer form.


      reply	other threads:[~2008-06-24  2:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-24  1:45 [RESEND][PATCH -mm 1/2] vfs: fix coding style at dcache.c Kentaro Makita
2008-06-24  2:07 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080623190705.04cedae2.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=harvey.harrison@gmail.com \
    --cc=k-makita@np.css.fujitsu.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.