From: Jens Axboe <jens.axboe@oracle.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Avoid bio_endio recursion
Date: Tue, 24 Jun 2008 10:07:44 +0200 [thread overview]
Message-ID: <20080624080744.GL20851@kernel.dk> (raw)
In-Reply-To: <Pine.LNX.4.64.0806240118250.24220@engineering.redhat.com>
On Tue, Jun 24 2008, Mikulas Patocka wrote:
> Hi
>
> bio_endio calls bi_end_io callback. In case of stacked devices (raid, dm),
> bio_end_io may call bio_endio again, up to an unspecified length.
>
> The crash because of stack overflow was really observed on sparc64. And
> this recursion was one of the contributing factors (using 9 stack frames
> --- that is 1728 bytes).
Looks good, I like the concept. Can you please make it a little less
goto driven, though? The next_bio and goto next_bio could just be a
while().
--
Jens Axboe
next prev parent reply other threads:[~2008-06-24 8:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 5:22 [PATCH 1/2] Avoid bio_endio recursion Mikulas Patocka
2008-06-24 6:08 ` Neil Brown
2008-06-24 14:36 ` Mikulas Patocka
2008-06-24 8:07 ` Jens Axboe [this message]
2008-06-24 14:27 ` Mikulas Patocka
2008-06-25 8:24 ` Jens Axboe
2008-06-26 0:13 ` Mikulas Patocka
2008-06-26 7:07 ` Jens Axboe
2008-07-02 4:09 ` Mikulas Patocka
2008-07-02 8:00 ` Alan Cox
2008-07-03 21:03 ` Mikulas Patocka
2008-07-02 8:25 ` Jens Axboe
2008-07-03 21:08 ` Mikulas Patocka
2008-07-03 21:04 ` Alan Cox
2008-07-03 22:54 ` Mikulas Patocka
2008-07-03 23:00 ` Alan Cox
2008-07-03 23:51 ` Mikulas Patocka
2008-07-03 23:44 ` Alan Cox
2008-07-04 3:26 ` Mikulas Patocka
2008-07-04 8:11 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080624080744.GL20851@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.