All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Buesch <mb@bu3sch.de>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: linville@tuxdriver.com, johannes@sipsolutions.net,
	yi.zhu@intel.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 4/4] mac80211: add phy information to giwname
Date: Tue, 24 Jun 2008 12:42:11 +0200	[thread overview]
Message-ID: <200806241242.11727.mb@bu3sch.de> (raw)
In-Reply-To: <1214303881-31525-5-git-send-email-tomas.winkler@intel.com>

On Tuesday 24 June 2008 12:38:01 Tomas Winkler wrote:
> This patch add phy information to giwname. Currently
> 802.11b is not treated.
> 
> Quoting:
> It's not useless, it's supposed to tell you about the protocol
> capability of the device, like "IEEE 802.11b" or "IEEE 802.11abg"

Well, I think it _is_ pretty useless.
However...

> @@ -135,7 +135,24 @@ static int ieee80211_ioctl_giwname(struct net_device *dev,
>  				   struct iw_request_info *info,
>  				   char *name, char *extra)
>  {
> +	struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
> +	struct ieee80211_supported_band *sband;
> +	u8 is_ht = 0;
> +
>  	strcpy(name, "IEEE 802.11");
> +	sband = local->hw.wiphy->bands[IEEE80211_BAND_5GHZ];
> +
> +	if (sband) {
> +		strcat(name, "a");
> +		is_ht |= sband->ht_info.ht_supported;
> +	}
> +	sband = local->hw.wiphy->bands[IEEE80211_BAND_2GHZ];
> +	if (sband) {
> +		strcat(name, "g");
> +		is_ht |= sband->ht_info.ht_supported;

What about b-only devices?

> +	}
> +	if (is_ht)
> +		strcat(name, "n");
>  
>  	return 0;
>  }



-- 
Greetings Michael.

  reply	other threads:[~2008-06-24 10:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-24 10:37 [PATCH 0/4] Minor WEXT fixes Tomas Winkler
2008-06-24 10:37 ` [PATCH 1/4] mac80211: don't return -EINVAL upon iwconfig wlan0 rts auto Tomas Winkler
2008-06-24 10:37   ` [PATCH 2/4] mac80211: update the authentication method Tomas Winkler
2008-06-24 10:38     ` [PATCH 3/4] mac80211: add last beacon time in scan list Tomas Winkler
2008-06-24 10:38       ` [PATCH 4/4] mac80211: add phy information to giwname Tomas Winkler
2008-06-24 10:42         ` Michael Buesch [this message]
2008-06-24 10:45           ` Johannes Berg
2008-06-24 10:54           ` Tomas Winkler
2008-06-24 11:03             ` Johannes Berg
2008-06-24 11:08               ` Tomas Winkler
2008-06-24 11:08             ` Michael Buesch
2008-06-24 11:28               ` Tomas Winkler
2008-06-24 14:03             ` Kalle Valo
2008-06-24 16:59               ` Tomas Winkler
2008-06-25 17:55                 ` Kalle Valo
2008-06-24 10:47       ` [PATCH 3/4] mac80211: add last beacon time in scan list Johannes Berg
2008-06-24 11:09         ` Dan Williams
2008-06-24 11:19           ` Johannes Berg
2008-06-24 11:12         ` Tomas Winkler
2008-06-24 10:49     ` [PATCH 2/4] mac80211: update the authentication method Johannes Berg
2008-06-24 11:03     ` Dan Williams
2008-06-24 10:47   ` [PATCH 1/4] mac80211: don't return -EINVAL upon iwconfig wlan0 rts auto Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200806241242.11727.mb@bu3sch.de \
    --to=mb@bu3sch.de \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=tomas.winkler@intel.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.