From: Andrew Morton <akpm@linux-foundation.org>
To: "Duane Griffin" <duaneg@dghda.com>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
sct@redhat.com, adilger@clusterfs.com, sliedes@cc.hut.fi,
duaneg@dghda.com
Subject: Re: [PATCH] ext3: handle deleting corrupted indirect blocks
Date: Tue, 24 Jun 2008 14:05:51 -0700 [thread overview]
Message-ID: <20080624140551.567149b6.akpm@linux-foundation.org> (raw)
In-Reply-To: <1214315240-22950-1-git-send-email-duaneg@dghda.com>
On Tue, 24 Jun 2008 14:47:20 +0100
"Duane Griffin" <duaneg@dghda.com> wrote:
> While freeing indirect blocks we attach a journal head to the parent buffer
> head, free the blocks, then journal the parent. If the indirect block list
> is corrupted and points to the parent the journal head will be detached
> when the block is cleared, causing an OOPS.
>
> Check for that explicitly and handle it gracefully.
>
> This patch fixes the third case (image hdb.20000057.nullderef.gz)
> reported in http://bugzilla.kernel.org/show_bug.cgi?id=10882.
Thanks.
Quite a few minorish ext3 fixes are coming in lately. Is anyone
checking whether they are needed in ext4 and if so, porting them
over?
-mm's current queue is:
ext3-fix-synchronization-of-quota-files-in-journal=data-mode.patch
ext3-fix-typos-in-messages-and-comments-journalled-journaled.patch
ext3-correct-mount-option-parsing-to-detect-when-quota-options-can-be-changed.patch
jbd-replace-potentially-false-assertion-with-if-block.patch
jbd-eliminate-duplicated-code-in-revocation-table-init-destroy-functions.patch
jbd-tidy-up-revoke-cache-initialisation-and-destruction.patch
ext3-improve-some-code-in-rb-tree-part-of-dirc.patch
jbd-fix-race-between-free-buffer-and-commit-trasanction.patch
jbd-fix-race-between-free-buffer-and-commit-trasanction-checkpatch-fixes.patch
jbd-fix-race-between-free-buffer-and-commit-trasanction-checkpatch-fixes-fix.patch
ext3-remove-double-definitions-of-xattr-macros.patch
ext3-handle-corrupted-orphan-list-at-mount.patch
ext3-handle-corrupted-orphan-list-at-mount-cleanup.patch
ext3-handle-corrupted-orphan-list-at-mount-fix.patch
ext3-handle-corrupted-orphan-list-at-mount-cleanup-fix.patch
ext3-dont-read-inode-block-if-the-buffer-has-a-write-error.patch
ext3-handle-deleting-corrupted-indirect-blocks.patch
next prev parent reply other threads:[~2008-06-24 21:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-10882-10286@http.bugzilla.kernel.org/>
2008-06-07 19:19 ` [Bugme-new] [Bug 10882] New: Different kernel crashes on corrupted filesystems Andrew Morton
2008-06-21 1:54 ` [PATCH] ext3: validate directory entry data before use Duane Griffin
2008-06-21 15:54 ` [PATCH, v2] " Duane Griffin
2008-06-21 16:13 ` Jochen Voß
2008-06-21 16:31 ` Duane Griffin
2008-06-21 16:31 ` Duane Griffin
2008-06-25 10:08 ` Jan Kara
2008-06-25 11:30 ` Duane Griffin
2008-06-25 12:11 ` [PATCH, v3] " Duane Griffin
2008-06-25 12:18 ` Jan Kara
2008-06-24 6:36 ` [PATCH] " Andreas Dilger
2008-06-23 21:56 ` [PATCH] ext3: handle corrupted orphan list at mount Duane Griffin
2008-06-23 22:32 ` Sami Liedes
2008-06-24 0:09 ` Duane Griffin
2008-06-24 16:08 ` Jan Kara
2008-06-24 17:16 ` Duane Griffin
2008-06-24 17:18 ` Jan Kara
2008-06-24 13:47 ` [PATCH] ext3: handle deleting corrupted indirect blocks Duane Griffin
2008-06-24 13:57 ` Eric Sandeen
2008-06-24 14:17 ` Duane Griffin
2008-06-24 21:05 ` Andrew Morton [this message]
2008-06-25 0:13 ` Mingming
2008-06-25 0:15 ` Duane Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080624140551.567149b6.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adilger@clusterfs.com \
--cc=duaneg@dghda.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sct@redhat.com \
--cc=sliedes@cc.hut.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.