From: xaiki@sgi.com (Niv Sardi)
To: melbourne@sgi.com, local@sgi.com, xfs@sgi.com, guys@sgi.com,
"p_bugpost.bug_groups.9:sgi.bugs.xfssgi.bugs.xfs"@engr.sgi.com,
xfs@oss.sgi.com
Subject: TAKE 976035 - streamline init/exit path
Date: Wed, 25 Jun 2008 13:00:57 +1000 (EST) [thread overview]
Message-ID: <20080625030057.973173A5D1@itchy> (raw)
streamline init/exit path
Currently the xfs module init/exit code is a mess. It's farmed out
over a lot of function with very little error checking. This patch
makes sure we propagate all initialization failures properly and clean
up after them. Various runtime initializations are replaced with
compile-time initializations where possible to make this easier. The
exit path is similarly consolidated.
There's now split out function to create/destroy the kmem zones and
alloc/free the trace buffers. I've also changed the ktrace
allocations to KM_MAYFAIL and handled errors resulting from that.
And yes, we really should replace the XFS_*_TRACE ifdefs with a single
XFS_TRACE..
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Niv Sardi <xaiki@sgi.com>
Date: Wed Jun 25 12:59:48 AEST 2008
Workarea: itchy.melbourne.sgi.com:/home/xaiki/Wrk/git/pmod2git
Inspected by: hch
The following file(s) were checked into:
longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb
Modid: xfs-linux-melb:xfs-kern:31354a
fs/xfs/xfs_da_btree.c - 1.182 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_da_btree.c.diff?r1=text&tr1=1.182&r2=text&tr2=1.181&f=h
fs/xfs/xfs_vfsops.c - 1.570 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_vfsops.c.diff?r1=text&tr1=1.570&r2=text&tr2=1.569&f=h
fs/xfs/xfs_mount.h - 1.272 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_mount.h.diff?r1=text&tr1=1.272&r2=text&tr2=1.271&f=h
fs/xfs/xfs_error.c - 1.63 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_error.c.diff?r1=text&tr1=1.63&r2=text&tr2=1.62&f=h
fs/xfs/xfs_error.h - 1.52 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_error.h.diff?r1=text&tr1=1.52&r2=text&tr2=1.51&f=h
fs/xfs/support/uuid.h - 1.16 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/support/uuid.h.diff?r1=text&tr1=1.16&r2=text&tr2=1.15&f=h
fs/xfs/support/uuid.c - 1.24 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/support/uuid.c.diff?r1=text&tr1=1.24&r2=text&tr2=1.23&f=h
fs/xfs/linux-2.6/xfs_stats.c - 1.26 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_stats.c.diff?r1=text&tr1=1.26&r2=text&tr2=1.25&f=h
fs/xfs/linux-2.6/xfs_stats.h - 1.18 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_stats.h.diff?r1=text&tr1=1.18&r2=text&tr2=1.17&f=h
fs/xfs/linux-2.6/xfs_super.c - 1.432 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_super.c.diff?r1=text&tr1=1.432&r2=text&tr2=1.431&f=h
fs/xfs/linux-2.6/xfs_sysctl.c - 1.46 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_sysctl.c.diff?r1=text&tr1=1.46&r2=text&tr2=1.45&f=h
fs/xfs/linux-2.6/xfs_sysctl.h - 1.31 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_sysctl.h.diff?r1=text&tr1=1.31&r2=text&tr2=1.30&f=h
fs/xfs/xfs_mru_cache.c - 1.9 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_mru_cache.c.diff?r1=text&tr1=1.9&r2=text&tr2=1.8&f=h
fs/xfs/xfs_filestream.c - 1.8 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_filestream.c.diff?r1=text&tr1=1.8&r2=text&tr2=1.7&f=h
next reply other threads:[~2008-06-25 3:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-25 3:00 Niv Sardi [this message]
2008-06-25 13:57 ` TAKE 976035 - streamline init/exit path Christoph Hellwig
2008-06-26 0:56 ` Niv Sardi
2008-06-26 23:54 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080625030057.973173A5D1@itchy \
--to=xaiki@sgi.com \
--cc="p_bugpost.bug_groups.9:sgi.bugs.xfssgi.bugs.xfs"@engr.sgi.com \
--cc=guys@sgi.com \
--cc=local@sgi.com \
--cc=melbourne@sgi.com \
--cc=xfs@oss.sgi.com \
--cc=xfs@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.