From: Bernhard Walle <bwalle@suse.de>
To: "Yinghai Lu" <yhlu.kernel@gmail.com>
Cc: "Ingo Molnar" <mingo@elte.hu>,
x86@kernel.org, vgoyal@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] e820_update_range(): Allow specifying ULLONG_MAX
Date: Wed, 25 Jun 2008 14:05:11 +0200 [thread overview]
Message-ID: <20080625140511.6660ff68@halley.suse.de> (raw)
In-Reply-To: <86802c440806241321g6c5cd64eoe504d6029de6fe5a@mail.gmail.com>
* Yinghai Lu [2008-06-24 13:21]:
>
> > it seems we should let the caller to use
> > e820_update_range(start, ULLONG_MAX - size,....)
> >
> > so you don't need to touch this func.
>
> or add sanitary check before using size in this func like
> if (size > ULLONG_MAX - start)
> size = ULLONG_MAX - start;
>
> e820_remove_range need to the same thing
I like that. I think the complexity should be in the function, and not
in the caller's function.
Bernhard
--
Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development
next prev parent reply other threads:[~2008-06-25 12:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 14:35 Limit E820 map when specifying mem parameter Bernhard Walle
2008-06-24 14:35 ` [PATCH 1/3] e820_update_range(): Strip size of original region Bernhard Walle
2008-06-24 19:57 ` Yinghai Lu
2008-06-25 12:04 ` Bernhard Walle
2008-06-24 14:35 ` [PATCH 2/3] e820_update_range(): Allow specifying ULLONG_MAX Bernhard Walle
2008-06-24 20:01 ` Yinghai Lu
2008-06-24 20:21 ` Yinghai Lu
2008-06-25 12:05 ` Bernhard Walle [this message]
2008-06-25 15:44 ` Ingo Molnar
2008-06-24 14:35 ` [PATCH 3/3] Limit E820 map when a user-defined memory map is specified Bernhard Walle
2008-06-24 20:03 ` Yinghai Lu
-- strict thread matches above, loose matches on Subject: below --
2008-06-25 12:02 Limit E820 map when specifying mem parameter Bernhard Walle
2008-06-25 12:02 ` [PATCH 2/3] e820_update_range(): Allow specifying ULLONG_MAX Bernhard Walle
2008-06-25 12:02 ` Bernhard Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080625140511.6660ff68@halley.suse.de \
--to=bwalle@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.