From: Andrew Morton <akpm@linux-foundation.org>
To: Rene Herman <rene.herman@keyaccess.nl>
Cc: bjorn.helgaas@hp.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PNP: have quirk_system_pci_resources() include io resources.
Date: Wed, 25 Jun 2008 14:16:21 -0700 [thread overview]
Message-ID: <20080625141621.28639b58.akpm@linux-foundation.org> (raw)
In-Reply-To: <4862873C.3070507@keyaccess.nl>
On Wed, 25 Jun 2008 19:58:20 +0200
Rene Herman <rene.herman@keyaccess.nl> wrote:
> + unsigned int type;
> +
> + type = pci_resource_flags(pdev, i) &
> + (IORESOURCE_IO | IORESOURCE_MEM);
pci_resource_flags() returns an unsigned long.
But I think you're right and resource.flags is wrong. Because there's
no way in which we'll ever be able to use bits 32-63 of that field
anyway.
I suppose that Someone(tm) should convert resource.flags to a u32 or
something. Minor issue.
next prev parent reply other threads:[~2008-06-25 21:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-25 17:58 [PATCH] PNP: have quirk_system_pci_resources() include io resources Rene Herman
2008-06-25 21:16 ` Andrew Morton [this message]
2008-06-25 21:46 ` Rene Herman
2008-06-25 22:16 ` Rene Herman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080625141621.28639b58.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rene.herman@keyaccess.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.