From: Matthew Wilcox <matthew@wil.cx>
To: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
Cc: Andy Gospodarek <andy@greyhouse.net>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"Allan, Bruce W" <bruce.w.allan@intel.com>,
"Ronciak, John" <john.ronciak@intel.com>,
netdev@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] igb: completely disable interrupts during netpoll
Date: Wed, 25 Jun 2008 14:35:19 -0600 [thread overview]
Message-ID: <20080625203519.GU4392@parisc-linux.org> (raw)
In-Reply-To: <36D9DB17C6DE9E40B059440DB8D95F52057B3B27@orsmsx418.amr.corp.intel.com>
On Wed, Jun 25, 2008 at 01:29:19PM -0700, Brandeburg, Jesse wrote:
> > - igb_irq_disable(adapter);
> > + disable_irq(adapter->pdev->irq);
>
> how does changing to disable_irq/enable_irq work with MSI and MSI-X
> interrupts?
Works just fine. There's a disable_irq method in the irq_chip that
knows how to disable a particular type of interrupt.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-06-25 20:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-25 14:15 [PATCH] igb: completely disable interrupts during netpoll Andy Gospodarek
2008-06-25 20:29 ` Brandeburg, Jesse
2008-06-25 20:35 ` Matthew Wilcox [this message]
2008-06-25 20:39 ` Andy Gospodarek
2008-06-26 0:29 ` David Miller
2008-06-26 2:40 ` Andy Gospodarek
2008-06-26 2:43 ` David Miller
2008-06-26 18:52 ` Jesse Barnes
2008-06-25 22:27 ` David Miller
2008-06-26 2:49 ` Andy Gospodarek
2008-06-26 7:23 ` Brandeburg, Jesse
2008-06-26 9:16 ` David Miller
2008-06-26 18:12 ` Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080625203519.GU4392@parisc-linux.org \
--to=matthew@wil.cx \
--cc=andy@greyhouse.net \
--cc=bruce.w.allan@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.