Re: [PATCH] configure: remove configure warning against not using gcc3

[Carlo Marcelo Arenas Belon <carenas@sajinet.com.pe>]

[-- Attachment #1: Type: text/plain, Size: 1329 bytes --]

On Wed, Jun 25, 2008 at 02:56:58PM +0300, Avi Kivity wrote:
> Carlo Marcelo Arenas Belon wrote:
> >
> >@@ -28,8 +28,6 @@ usage() {
> > 
> > 	Any additional option is given to qemu's configure verbatim; 
> > 	including:
> > 
> >-	    --disable-gcc-check    don't insist on gcc-3.x
> >-	                           CAUTION: this will break running without 
> >kvm
> >  
> 
> You've orphaned the "including:" above!

not sure what you mean by that.

if you think I forgot to remove it, I did not, as my intention was for the 
"including;" to be part of the message that clearly explained (or so I though)
that all options below it were coming from qemu's configure instead as shown
by the following snippet of the relevant output from ./configure --help
after the patch has been applied to kvm-70:

...
    --qemu-ldflags=LDFLAGS LDFLAGS to add to qemu configuration

Any additional option is given to qemu's configure verbatim; including:

    --disable-werror       disable compilation abort on warning
    --disable-sdl          disable SDL
...

if you think that it should had been removed with the message about the
additional options, so that all options are now shown together and the fact
that they are really from qemu is transparent (which I think might be indeed
a better idea) then use instead the attached patch.

Carlo

[-- Attachment #2: 0001-complement-ff5396cfeacf74ad9611a35e882ff100b10126aci.patch --]
[-- Type: text/plain, Size: 1323 bytes --]

>From 4258e622913a63d6f766374bf17a59524529eae5 Mon Sep 17 00:00:00 2001
From: Carlo Marcelo Arenas Belon <carenas@sajinet.com.pe>
Date: Thu, 26 Jun 2008 01:03:20 -0700
Subject: [PATCH] configure: remove configure warning against not using gcc3

complement ff5396cfeacf74ad9611a35e882ff100b10126aci, removing the
warning printed by ./configure --help which recommended against using
gcc4 as it wasn't supported by dyngen.

make all qemu inherited options that could be detected completely
transparent as the only one that needed special handling is now the
default.

Signed-off-by: Carlo Marcelo Arenas Belon <carenas@sajinet.com.pe>
---
 configure |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/configure b/configure
index 902e769..a158051 100755
--- a/configure
+++ b/configure
@@ -25,11 +25,6 @@ usage() {
 	    --kerneldir=DIR        kernel build directory ($kerneldir)
 	    --qemu-cflags=CFLAGS   CFLAGS to add to qemu configuration
 	    --qemu-ldflags=LDFLAGS LDFLAGS to add to qemu configuration
-
-	Any additional option is given to qemu's configure verbatim; including:
-
-	    --disable-gcc-check    don't insist on gcc-3.x
-	                           CAUTION: this will break running without kvm
 EOF
     cd qemu
     ./configure --help | egrep "enable-|disable-" \
-- 
1.5.4.5